Decouple TemplateProcessorTest from RefasterTemplateProcessor #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
commented
Jan 3, 2024
Comment on lines
+25
to
+26
| JavaTemplate.Builder before = Semantics.expression(this, "before", (String s) -> s.equals(s)); | ||
| JavaTemplate.Builder after = Semantics.expression(this, "after", (String s) -> true); |
There was a problem hiding this comment.
The goal here is to more closely match the use in rewrite-micrometer, such that we can troubleshoot that more easily:
https://github.com/openrewrite/rewrite-micrometer/blob/4e4e71a0b2e8dd78477a4fcac711d6048dc3577c/src/main/java/org/openrewrite/micrometer/misk/NoExplicitEmptyLabelList.java#L50-L57
|
Going to merge this one as I've only changes classes in src/test, such that I can build on this for a hopeful fix for the missing TemplateProcessor classpath entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ahead of
I'd considered also changing the tests to no longer use files as in and output but text blocks, but figured we can discuss and pick that up separately.