Do not register a conflict for qualified method calls

openrewrite · Aug 18, 2024 · 8e001a9 · 8e001a9
1 parent 41135d4
commit 8e001a9
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/src/main/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefix.java b/src/main/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefix.java
@@ -127,7 +127,7 @@ public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method,
             new JavaIsoVisitor<AtomicBoolean>() {
                 @Override
                 public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, AtomicBoolean atomicBoolean) {
-                    if (method.getName().getSimpleName().equals(newMethodName)) {
+                    if (method.getName().getSimpleName().equals(newMethodName) && method.getSelect() == null) {
                         skip.set(true);
                     }
                     return super.visitMethodInvocation(method, atomicBoolean);

diff --git a/src/test/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefixTest.java b/src/test/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefixTest.java
@@ -327,7 +327,7 @@ void tests() {
 
     @Test
     @Issue("https://github.com/openrewrite/rewrite-testing-frameworks/issues/258")
-    void removeTestPrefixWithClashingMethod() {
+    void ignoreWhenStaticImportConflicts() {
         rewriteRun(
           //language=java
           java(
@@ -345,4 +345,36 @@ void testOf() {
           )
         );
     }
+
+    @Test
+    @Issue("https://github.com/openrewrite/rewrite-testing-frameworks/issues/258")
+    void removeOnQualifiedMethodDespiteConflict() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import org.junit.jupiter.api.Test;
+              import java.util.List;
+
+              class FooTest {
+                  @Test
+                  void testOf() {
+                    List.of();
+                  }
+              }
+              """,
+            """
+              import org.junit.jupiter.api.Test;
+              import java.util.List;
+
+              class FooTest {
+                  @Test
+                  void of() {
+                    List.of();
+                  }
+              }
+              """
+          )
+        );
+    }
 }