Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration from Easymock to Mockito #639

Merged
merged 37 commits into from
Dec 10, 2024
Merged

Migration from Easymock to Mockito #639

merged 37 commits into from
Dec 10, 2024

Conversation

jevanlingen
Copy link
Contributor

@jevanlingen jevanlingen commented Nov 8, 2024 •
edited by timtebeek
Loading

What's changed?

EasyMock to Mockito support.

What's your motivation?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jevanlingen jevanlingen self-assigned this Nov 8, 2024
@jevanlingen jevanlingen linked an issue Nov 8, 2024 that may be closed by this pull request
EasyMock to Mockito #454
Closed
@jevanlingen jevanlingen requested a review from timtebeek November 8, 2024 16:21
github-actions[bot]
github-actions bot reviewed Nov 8, 2024
View reviewed changes
src/main/java/org/openrewrite/java/testing/easymock/EasyMockVerifyToMockitoVerify.java Outdated Show resolved Hide resolved
src/main/java/org/openrewrite/java/testing/easymock/EasyMockVerifyToMockitoVerify.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/java/testing/easymock/EasyMockToMockitoTest.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/java/testing/easymock/EasyMockToMockitoTest.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/java/testing/easymock/EasyMockToMockitoTest.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/java/testing/easymock/EasyMockVerifyToMockitoVerifyTest.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/java/testing/easymock/RemoveExtendsEasyMockSupportTest.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/java/testing/easymock/RemoveExtendsEasyMockSupportTest.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/java/testing/easymock/RemoveExtendsEasyMockSupportTest.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/java/testing/easymock/RemoveExtendsEasyMockSupportTest.java Outdated Show resolved Hide resolved
jevanlingen and others added 3 commits November 9, 2024 11:34
@jevanlingen @github-actions
Apply suggestions from code review
7d5b9dc 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jevanlingen
Apply suggestions from code review
7170a29
@jevanlingen
Improve EasyMockVerifyToMockitoVerifyTest to prove the implementati…
5996cd7 
…on is not totally right yet
jevanlingen and others added 2 commits November 11, 2024 12:06
@jevanlingen
Improve NoInitializationForInjectMock
d6a4fb1
@jevanlingen @github-actions
Apply suggestions from code review
f7aa62c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jevanlingen and others added 2 commits November 11, 2024 15:44
@jevanlingen @github-actions
Apply suggestions from code review
0f7da3c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@timtebeek
Merge branch 'main' into 454-easymock-to-mockito
5bd7ed7
timtebeek
timtebeek reviewed Nov 18, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
@timtebeek timtebeek marked this pull request as draft November 18, 2024 14:29
@dralagen dralagen mentioned this pull request Dec 6, 2024
Merged
3 tasks
@jevanlingen jevanlingen marked this pull request as ready for review December 10, 2024 17:04
timtebeek
timtebeek approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see Easymock covered as well! Thanks for taking over from the comment shared by @dblackhall-tyro to get a fully working implementation, complete with improvements for Mockito as well.

@timtebeek timtebeek merged commit 1d1b915 into main Dec 10, 2024
2 checks passed
@timtebeek timtebeek deleted the 454-easymock-to-mockito branch December 10, 2024 20:03
@timtebeek timtebeek changed the title Migration from easymock to mockito Migration from Easymock to Mockito Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@dralagen dralagen dralagen left review comments

@knutwannheden knutwannheden knutwannheden left review comments

@timtebeek timtebeek timtebeek approved these changes

Assignees

@jevanlingen jevanlingen

Labels
easymock
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EasyMock to Mockito
4 participants
@jevanlingen @knutwannheden @timtebeek @dralagen