Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemanticallyEqual does not evaluate fully qualified names as equal to eachother, or to simple names #345

Closed
pway99 opened this issue Mar 3, 2021 · 0 comments
Closed

SemanticallyEqual does not evaluate fully qualified names as equal to eachother, or to simple names #345

pway99 opened this issue Mar 3, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@pway99
Copy link
Contributor

pway99 commented Mar 3, 2021

fully qualified annotations types are nested under J.FieldAccess which is not supported by SemanticallyEquals
@pway99 pway99 added the bug Something isn't working label Mar 3, 2021
@sambsnyd sambsnyd changed the title SemanticallyEqual bug when annotation is fully qualified SemanticallyEqual does not evaluate fully qualified names as equal to eachother, or to simple names Mar 5, 2021
@pway99 pway99 closed this as completed in a23a23f Mar 7, 2021
nmck257 pushed a commit that referenced this issue Nov 12, 2024
@knutwannheden @sambsnyd @nmck257
Update for rewrite 8.0 (#345)
0733628 
* Update for rewrite 8.0

* Cosmetics

* Fix a few more issues

* Fix a few more test failures

* Fix a few more test failures

* Upgrade recipes to new `JavaTemplate` API

* Replace `getRecipeList()` overrides with `@Getter(lazy = true)` property

* Consistently use `latest.release` or `latest.integration`

* Revert "Replace `getRecipeList()` overrides with `@Getter(lazy = true)` property"

This reverts commit 897d59e79c9515564da45911ce2246934c5b1ae7.

* Migrate to new `Recipe#getInitialState(ExecutionContext)` API

* Polish

* Fix a broken test

Due to reversal of logic after inlining `doAfterVisit()` logic.

* Fix another broken test

We should change the `UpgradeDependencyVersion` in `rewrite-java-dependencies` so that workarounds like this are not necessary.

* Fix last failing test (use `doAfterVisit()` again)

---------

Co-authored-by: Sam Snyder <sam@moderne.io>
nmck257 pushed a commit that referenced this issue Nov 12, 2024
@knutwannheden @sambsnyd @nmck257
Update for rewrite 8.0 (#345)
9c5da30 
* Update for rewrite 8.0

* Cosmetics

* Fix a few more issues

* Fix a few more test failures

* Fix a few more test failures

* Upgrade recipes to new `JavaTemplate` API

* Replace `getRecipeList()` overrides with `@Getter(lazy = true)` property

* Consistently use `latest.release` or `latest.integration`

* Revert "Replace `getRecipeList()` overrides with `@Getter(lazy = true)` property"

This reverts commit 897d59e79c9515564da45911ce2246934c5b1ae7.

* Migrate to new `Recipe#getInitialState(ExecutionContext)` API

* Polish

* Fix a broken test

Due to reversal of logic after inlining `doAfterVisit()` logic.

* Fix another broken test

We should change the `UpgradeDependencyVersion` in `rewrite-java-dependencies` so that workarounds like this are not necessary.

* Fix last failing test (use `doAfterVisit()` again)

---------

Co-authored-by: Sam Snyder <sam@moderne.io>
MBoegers pushed a commit to MBoegers/rewrite that referenced this issue Dec 18, 2024
@knutwannheden @sambsnyd @MBoegers
Update for rewrite 8.0 (openrewrite#345)
d560871 
* Update for rewrite 8.0

* Cosmetics

* Fix a few more issues

* Fix a few more test failures

* Fix a few more test failures

* Upgrade recipes to new `JavaTemplate` API

* Replace `getRecipeList()` overrides with `@Getter(lazy = true)` property

* Consistently use `latest.release` or `latest.integration`

* Revert "Replace `getRecipeList()` overrides with `@Getter(lazy = true)` property"

This reverts commit 897d59e79c9515564da45911ce2246934c5b1ae7.

* Migrate to new `Recipe#getInitialState(ExecutionContext)` API

* Polish

* Fix a broken test

Due to reversal of logic after inlining `doAfterVisit()` logic.

* Fix another broken test

We should change the `UpgradeDependencyVersion` in `rewrite-java-dependencies` so that workarounds like this are not necessary.

* Fix last failing test (use `doAfterVisit()` again)

---------

Co-authored-by: Sam Snyder <sam@moderne.io>
MBoegers pushed a commit to MBoegers/rewrite that referenced this issue Dec 18, 2024
@knutwannheden @sambsnyd @MBoegers
Update for rewrite 8.0 (openrewrite#345)
8b9d397 
* Update for rewrite 8.0

* Cosmetics

* Fix a few more issues

* Fix a few more test failures

* Fix a few more test failures

* Upgrade recipes to new `JavaTemplate` API

* Replace `getRecipeList()` overrides with `@Getter(lazy = true)` property

* Consistently use `latest.release` or `latest.integration`

* Revert "Replace `getRecipeList()` overrides with `@Getter(lazy = true)` property"

This reverts commit 897d59e79c9515564da45911ce2246934c5b1ae7.

* Migrate to new `Recipe#getInitialState(ExecutionContext)` API

* Polish

* Fix a broken test

Due to reversal of logic after inlining `doAfterVisit()` logic.

* Fix another broken test

We should change the `UpgradeDependencyVersion` in `rewrite-java-dependencies` so that workarounds like this are not necessary.

* Fix last failing test (use `doAfterVisit()` again)

---------

Co-authored-by: Sam Snyder <sam@moderne.io>
knutwannheden added a commit that referenced this issue Mar 4, 2025
@knutwannheden
Fix the formatting of chained function calls with parameters (#345)
5f5f2ed 
For details see #3616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pway99