Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle version parsing error when no semver is used #4655

Closed
Jenson3210 opened this issue Nov 8, 2024 — with Slack · 2 comments
Closed

Gradle version parsing error when no semver is used #4655

Jenson3210 opened this issue Nov 8, 2024 — with Slack · 2 comments

Comments

@Jenson3210 Slack
Copy link
Contributor

Jenson3210 commented Nov 8, 2024 •
edited
Loading

Reproduction available in branch

https://rewriteoss.slack.com/archives/C01A843MWG5/p1730974519581749
Jenson3210 added a commit to Jenson3210/rewrite that referenced this issue Nov 8, 2024
@Jenson3210
Catch the exception that gets thrown in case of a non semver version …
18f9bc3 
…number

Fixes openrewrite#4655
Jenson3210 added a commit to Jenson3210/rewrite that referenced this issue Nov 8, 2024
@Jenson3210
Catch the exception that gets thrown in case of a non semver version …
45f0173 
…number

Fixes openrewrite#4655
@mccartney
Copy link
Contributor

mccartney commented Nov 8, 2024 •
edited by timtebeek
Loading

@Jenson3210
Copy link
Contributor Author

Yes indeed. I raised it as part of a slack chat. Probably the person who raised in slack also raised here.

shanman190 pushed a commit that referenced this issue Nov 11, 2024
@Jenson3210
Catch non-semver compatible exception in case of version update (#4656)
4391062 
* Catch the exception that gets thrown in case of a non semver version number

* Catch the exception that gets thrown in case of a non semver version number

Fixes #4655

* Catch the exception that gets thrown in case of a non semver version number

Fixes #4655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mccartney @Jenson3210