Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite-Maven update plugin configuration recipe #571

Closed
pway99 opened this issue May 24, 2021 · 1 comment
Closed

Rewrite-Maven update plugin configuration recipe #571

pway99 opened this issue May 24, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pway99
Copy link
Contributor

pway99 commented May 24, 2021

Add recipe for updating maven plugin configuration.
required for rewrite-quarkus


Gershman edits:
I'm thinking this can be broken into a fundamental discrete which relies on xpath matcher to include children selection criteria. As in, being able to specify an xpath matcher with predicates such as

/project/build/plugins/plugin[artifactId="rewrite-maven-plugin"]/configuration/activeRecipes

This would give us multiple benefits:

  • 1.) we'd be able to offer this path selection for adding and removing arbitrary configuration keys, and
  • 2.) we'd ostensibly be able to reuse this for rewrite-yaml, and thus rewrite-kubernetes to be able to do element selection criteria. It's basically impossible to select elements from lists without this.

That might make the most sense

@aegershman
Copy link
Contributor

an example of updating plugin configuration can be seen here: (openrewrite/rewrite-quarkus#26)
But it's not some special function to being in a plugin block. It's just normal xml tag traversal.

Closing this in general, but opened an issue on observations about declarative path matching in #593

knutwannheden added a commit that referenced this issue Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants