Add recipe to replace text blocks with strings #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sympathize with you there having to downgrade and appreciate the recipes! Just to be sure we've covered all cases, would you mind adding a test with a comment just before the text block? Want to make sure we're not accidentally removing those comments with the current implementation, or any changes after this is merged. |
|
In either case these tests are going to come in handy (in reverse) when we implement #2742, and hopefully for you in the future! |
|
I agree that comments should not be removed. Added tests and fixed the recipe. |
|
Thanks for contributing all of these back, @AresEkb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe such a recipe will be useful, if it doesn't already exist.