Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to JSpecify from OpenRewrite JSR-305 meta-annotations #4418

Merged
merged 13 commits into from
Aug 15, 2024

Conversation

jkschneider
Copy link
Member

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-core/src/test/java/org/openrewrite/RecipeValidationTest.java
    • lines 36-38

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-core/src/test/java/org/openrewrite/RecipeValidationTest.java
    • lines 36-38

@jkschneider
Copy link
Member Author

JSpecify @NonNull is enforced at runtime by Lombok generated constructors based on this annotation's presence on fields. This was not true for OpenRewrite's @NonNull so there is a bit of behavior change here. For now, we'll keep references to OpenRewrite @NonNull on fields and deal with this in another iteration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-core/src/test/java/org/openrewrite/RecipeValidationTest.java
    • lines 36-38

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-core/src/test/java/org/openrewrite/RecipeValidationTest.java
    • lines 36-38

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-core/src/test/java/org/openrewrite/RecipeValidationTest.java
    • lines 37-37

@jkschneider jkschneider merged commit a98d83d into main Aug 15, 2024
2 checks passed
@jkschneider jkschneider deleted the refactor/migrate-to-jspecify3 branch August 15, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants