Reworked ExcludeFileFromGitignore to support leading and trailing wildcards #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenson3210
changed the title
lkerford
reviewed
Nov 6, 2024
| @@ -268,4 +220,190 @@ private IgnoreNode.MatchResult isIgnored(IgnoreNode ignoreNode, String path) { | |||
| return CHECK_PARENT; | |||
| } | |||
| } | |||
|
|
|||
| private static class IgnoreRule { | |||
There was a problem hiding this comment.
I do wonder if we should be applying these changes in our fork of jGit instead, but I think that given we are also making changes to how we want the changes written this is fine
lkerford
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
There's a bug in the currect version with
**/path/entries. This should be fixed by adding the support + tests.What's your motivation?
Fix the bug + add wildcard support. We do not support wildcards in the middle part of a path, nor entries with multiple wildcarded parts. Also only the * wildcard for now is supported. Not the
?yet.Anyone you would like to review specifically?
@lkerford , I thought I said I am DONE with gitignore and NEVER want to see them again... Yet here we go ;)
Checklist
Note: when I run the best practices, I also receive changes in lots of other files, so only kept these applicable on my 2 changed files.