Append items to annotation attribute array #4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdebruin
changed the title
nielsdebruin
changed the title
nielsdebruin
changed the title
|
I think your first proposed option is the way to go. You'd want to separately be able to specify whether you only want to add a property value when it's missing but also be able to specify whether you want to replace or append the new value(s) |
nielsdebruin
force-pushed
the
4157-allow-addorupdateannotationattribute-to-add-values-to-an-array
branch
from
f49737c to
268f576
Compare
Laurens-W
reviewed
Nov 15, 2024
rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 19, 2024
rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 19, 2024
rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 19, 2024
rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Nov 19, 2024
…otationAttribute.java Co-authored-by: Tim te Beek <tim@moderne.io>
timtebeek
deleted the
4157-allow-addorupdateannotationattribute-to-add-values-to-an-array
branch
MBoegers
pushed a commit
to MBoegers/rewrite
that referenced
this pull request
Dec 18, 2024
* Add some initial tests * Add append functionality * Add markers * Fix constructor after merge * Polish code * Verify default behavior retained for declarative recipes through use of `null` in tests * Add test that fails due to unexpected second cycle * Adopt Markers.findFirst * Add newline to indicate Marker is on assignment * Fix test and polish * Update rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java Co-authored-by: Tim te Beek <tim@moderne.io> --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR enhances the functionality of the
AddOrUpdateAnnotationAttributerecipe, allowing not only to override but also to append to array values. A new option,arrayAppend, has been introduced, enabling users to append to attributes with anarraytype. When used in conjunction with theaddOnlyoption, users can control whether a value will be appended only if it is not already present, thereby avoiding duplication.What's your motivation?
AddOrUpdateAnnotationAttributeto add values to an array #4157Anyone you would like to review specifically?
@timtebeek @Laurens-W
Checklist