Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add import for Record classes not from java.lang package, to avoid conflicts on Java 14+ #4787

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

BramliAK
Copy link
Contributor

@BramliAK BramliAK commented Dec 15, 2024

What's changed?

Force Importing No Java Record

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek changed the title Force Importing No Java Record Always add import for Record classes not from java.lang package, to avoid conflicts on Java 14+ Dec 15, 2024
@timtebeek timtebeek self-requested a review December 15, 2024 17:27
@timtebeek
Copy link
Contributor

hi @BramliAK ! Thanks for the change; would you mind describing what additional cases this covers beyond what's seen in

I do know we had that disabled test there; wonder if this aims to fix that one as well.

@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Dec 15, 2024
@timtebeek
Copy link
Contributor

Ah I only just now saw your comment here; thanks!

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted @BramliAK ; thanks a lot!

@timtebeek timtebeek merged commit 36acd59 into openrewrite:main Dec 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants