Improve discovery of parentheses level for MethodCallExpression #4834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Parentheses discovery for method calls did not always work properly.
What's your motivation?
Failing parts:
Any additional context
The discovery of parentheses is quite hard to grasp. This is the concept behind it. We defined two variables called
parent
andchild
. The parent and child are nodes, which could be visualised like:<<child> parent>
. Notice in source code, the nodes could span multiple lines.To support this, we loop through all the lines of code of the parent and child element:
Checklist