Add TOML language parser #4845
Merged
Add TOML language parser #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-toml/src/main/java/org/openrewrite/toml/internal/TomlPrinter.java
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/TomlPrinter.java
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/TomlPrinter.java
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/TomlPrinter.java
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/TomlPrinter.java
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlParserListener.java
Outdated
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlParserVisitor.java
Outdated
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/tree/TomlRightPadded.java
Outdated
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlLexer.java
Outdated
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlParser.java
Outdated
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlParserBaseListener.java
Outdated
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlParserBaseVisitor.java
Outdated
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlParserListener.java
Outdated
Show resolved
Hide resolved
rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlParserVisitor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ar/TomlParserVisitor.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sambsnyd
reviewed
Jan 3, 2025
| import static java.util.Collections.emptyList; | ||
|
|
||
| /** | ||
| * Wherever whitespace can occur in JSON, so can comments (at least block style comments). |
There was a problem hiding this comment.
Suggested change
| * Wherever whitespace can occur in JSON, so can comments (at least block style comments). | |
| * Wherever whitespace can occur in TOML, so can comments (at least block style comments). |
sambsnyd
approved these changes
Jan 3, 2025
| int5 = 1_000 | ||
|
|
||
| # hexadecimal with prefix `0x` | ||
| hex1 = 0xDEADBEEF |
There was a problem hiding this comment.
Ah the classic 0xDEADBEEF I was so baffled/amused the first time I saw that value while debugging
This was referenced Jan 3, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Implemented a language parser for TOML.
What's your motivation?
Finished implementation that was started in #4678. After speaking with @steplica, he felt that he didn't have the time to finish up the implementation and didn't feel the need for direct credit (but credit still here!), but sincerely appreciated the exercise and assistance in #4678 working through how to build a parser and the inner workings of the language bindings.
Anything in particular you'd like reviewers to focus on?
LST structure, other issues
Anyone you would like to review specifically?
Anybody is welcome. :)
Have you considered any alternatives or workarounds?
In #4678, there is an initial implementation. Concurrently with Steve, I was working on my own copy of the TOML parser. As you can see, the implementations diverged slightly, but are still true to the same common grammar.
Any additional context
None
Checklist