Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure TCCL in InMemoryLargeSurceSet to enable ServiceLoader #5034

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
+36 −13
Open

Configure TCCL in InMemoryLargeSurceSet to enable ServiceLoader #5034

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fcd91f2
Refactor `SourceFileWithReferences#getReferences` method to accept a …
MBoegers Feb 13, 2025
bc55cd6
Apply suggestions from code review
timtebeek Feb 13, 2025
82cfc32
Merge branch 'main' into load-provider-with-defined-classloader
MBoegers Feb 14, 2025
25025b1
remove ClassLoader as parameter of getReferences
MBoegers Feb 14, 2025
eacff9f
set TCCL globally before recipe execution
MBoegers Feb 14, 2025
008218c
remove parameter from calls
MBoegers Feb 14, 2025
431e371
remove artefact
MBoegers Feb 14, 2025
049e615
remove artefact
MBoegers Feb 14, 2025
b393a74
Merge branch 'main' into load-provider-with-defined-classloader
MBoegers Feb 17, 2025
596328b
rollback changes
MBoegers Feb 21, 2025
8117508
use `InMemoryLargeSourceSet` to set TCCL properly
MBoegers Feb 21, 2025
9647f6f
Merge branch 'main' into load-provider-with-defined-classloader
MBoegers Feb 21, 2025
9b182fe
move adjustments to the TCCL into edit method to avoid thread related…
MBoegers Feb 24, 2025
09ccc20
Merge branch 'main' into load-provider-with-defined-classloader
MBoegers Feb 24, 2025
06f9240
remove not needed methods
MBoegers Feb 24, 2025
dacd1d6
propose reusable composite loader that delegates calls to a list of c…
MBoegers Feb 26, 2025
a1000ae
Merge branch 'main' into load-provider-with-defined-classloader
MBoegers Feb 26, 2025
db8f9f3
add license informations
MBoegers Feb 26, 2025
d5d1c74
remove CompositClassLoader.java
MBoegers Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rewrite-core/src/main/java/org/openrewrite/RecipeScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public RecipeRun scheduleRun(Recipe recipe,
int maxCycles,
int minCycles) {
try {
Thread.currentThread().setContextClassLoader(recipe.getClass().getClassLoader());
LargeSourceSet after = runRecipeCycles(recipe, sourceSet, ctx, maxCycles, minCycles);
return new RecipeRun(
after.getChangeset(),
Expand Down
13 changes: 7 additions & 6 deletions rewrite-gradle/src/test/java/org/openrewrite/gradle/AddDependencyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,19 @@

import org.intellij.lang.annotations.Language;
import org.jspecify.annotations.Nullable;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.openrewrite.ExecutionContext;
import org.openrewrite.Issue;
import org.openrewrite.Recipe;
import org.openrewrite.TreeVisitor;
import org.openrewrite.gradle.marker.GradleDependencyConfiguration;
import org.openrewrite.gradle.marker.GradleProject;
import org.openrewrite.java.JavaParser;
import org.openrewrite.java.JavaVisitor;
import org.openrewrite.java.tree.J;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
Expand All @@ -36,12 +42,7 @@
import static org.openrewrite.gradle.toolingapi.Assertions.withToolingApi;
import static org.openrewrite.groovy.Assertions.groovy;
import static org.openrewrite.groovy.Assertions.srcMainGroovy;
import static org.openrewrite.java.Assertions.java;
import static org.openrewrite.java.Assertions.mavenProject;
import static org.openrewrite.java.Assertions.srcMainJava;
import static org.openrewrite.java.Assertions.srcMainResources;
import static org.openrewrite.java.Assertions.srcSmokeTestJava;
import static org.openrewrite.java.Assertions.srcTestJava;
import static org.openrewrite.java.Assertions.*;
import static org.openrewrite.properties.Assertions.properties;

@SuppressWarnings("GroovyUnusedAssignment")
Expand Down