rewise RemoveUnusedImportsVisitor
#5055
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ExecutionContextJavaIsoVisitor # Conflicts: # rewrite-java/src/main/java/org/openrewrite/java/RemoveUnusedImports.java
punkratz312
changed the title
RemoveUnusedImports and extract RemoveUnusedImportsJavaIsoVisitor
punkratz312
changed the title
RemoveUnusedImports and extract RemoveUnusedImportsJavaIsoVisitorRemoveUnusedImportsVisitor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-java/src/main/java/org/openrewrite/java/RemoveUnusedImports.java
Outdated
Show resolved
Hide resolved
rewrite-java/src/main/java/org/openrewrite/java/RemoveUnusedImports.java
Outdated
Show resolved
Hide resolved
rewrite-java/src/main/java/org/openrewrite/java/RemoveUnusedImports.java
Outdated
Show resolved
Hide resolved
…ports.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ports.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ports.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
punkratz312
commented
Feb 25, 2025
| // whenever an import statement is found to be used and not already in use it should be marked true | ||
| Set<String> checkedImports = new HashSet<>(); | ||
| Set<String> usedWildcardImports = new HashSet<>(); | ||
| Set<String> usedStaticWildcardImports = new HashSet<>(); | ||
| ImportLayoutStyle layoutStyle = |
There was a problem hiding this comment.
|
Is this any good, @MBoegers? It's quite a lot of code, and the block is long, containing what seems to be another class with subroutines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically only extract till you drop and there is a lot to be extracted from 👍
Mainly applied: https://checkstyle.sourceforge.io/checks/coding/variabledeclarationusagedistance.html
example: openrewrite/rewrite-static-analysis#469