chore: integration test for bindmountapi #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madwort
force-pushed
the
madwort/bindmount-integration-test
branch
from
6b53f1e to
8637b35
Compare
madwort
force-pushed
the
madwort/bindmount-integration-test
branch
from
8637b35 to
b8d43b9
Compare
* do not move the volume_api fixture because it is currently slightly different for the two tests
|
ah, I misunderstood - this was a separate test broken by a refactoring in this PR. now fixed. |
* this was imported the function from executors.local, which was in turn importing it from executors.volumes. When the import was changed in executors.local this broke some other imports.
madwort
force-pushed
the
madwort/bindmount-integration-test
branch
from
1eb2795 to
f072a4f
Compare
bloodearnest
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests currently only run using one of the APIs that we support. We should run the tests on both APIs, which will hopefully catch more bugs more quickly.