chore: set safer bash config #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems that |
|
this is failing because the test is attempting to use pydantic-2 and pipeline only supports pydantic-1 - see opensafely-core/pipeline#159 |
madwort
force-pushed
the
madwort/safer-bash
branch
from
b3d4f31 to
1152721
Compare
|
rebased on pydantic-2 - now blocked by the colima issue #641 |
madwort
force-pushed
the
madwort/safer-bash
branch
2 times, most recently
from
3354a9b to
a2a9378
Compare
madwort
force-pushed
the
madwort/safer-bash
branch
from
61f6b14 to
4235388
Compare
madwort
commented
Sep 1, 2023
* this grep was verifying there was at least one non-test, *not* that there were no tests
madwort
force-pushed
the
madwort/safer-bash
branch
from
4235388 to
4920a00
Compare
madwort
commented
Sep 1, 2023
Comment on lines
+149
to
+152
| if unzip -Z -1 dist/*.whl | grep -q "^tests"; then | ||
| echo "Built wheel contains tests!" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
tom@MadBook3 just-and-shell-tests % unzip -Z -1 does-not-contain-tests.zip | grep "^tests"
tom@MadBook3 just-and-shell-tests % unzip -Z -1 contains-tests.zip | grep "^tests"
tests/
tests/file3
tom@MadBook3 just-and-shell-tests % cat not-in-list.sh
#!/bin/bash
set -euo pipefail
if unzip -Z -1 contains-tests.zip | grep -q "^tests"; then
echo "contains tests"
else
echo "does not contain tests"
fi
if unzip -Z -1 does-not-contain-tests.zip | grep -q "^tests"; then
echo "contains tests"
else
echo "does not contain tests"
fi
tom@MadBook3 just-and-shell-tests % ./not-in-list.sh
contains tests
does not contain tests
ghickman
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.