Sort jobs by if they need db or not #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodearnest
force-pushed
the
db-sorting
branch
from
f1b1abf
to
00bf96b
Compare
madwort
approved these changes
Aug 30, 2023
This adds a natural priority to db jobs, ensuring they will always be considered before cpu jobs. Currently, enough cpu jobs to hit MAX_WORKERS will block db jobs from starting, as they will be considered first. Note, this is still sorted *after* workspace, so the fairness is still preserved. There are not tests for this, as this code currently has no test coverage, as its a bit fiddly to implement.
bloodearnest
force-pushed
the
db-sorting
branch
from
47aa341
to
d538405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a natural priority to db jobs, ensuring they will always be
considered before cpu jobs.
Currently, enough cpu jobs to hit MAX_WORKERS will block db jobs from
starting, as they will be considered first.
Note, this is still sorted after workspace, so the fairness is still
preserved.
There are not tests for this, as this code currently has no test
coverage, as its a bit fiddly to implement.
Pulling in the bug fix from other branch, as its affect tests here, but am waiting on review for that branch