Remove old database names and add new ones #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Database names are now only added to the config if a value for them exists in the environment. This means that job-runner instances will refuse to accept job requests for databases they have not been configured to run, rather than accepting the job and then throwing an error later.
evansd
force-pushed
the
evansd/db-config
branch
from
f6c4e22
to
6bf3f43
Compare
ghickman
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparatory as the new ones are not yet in use. We also change the configuration behaviour so that database names are now only added to the config if a value for them exists in the environment. This means that job-runner instances will refuse to accept job requests for databases they have not been configured to run, rather than accepting the job and then throwing an error later.