Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset cumulative metrics after job restart #708

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

evansd
Copy link
Contributor

@evansd evansd commented Feb 8, 2024

This involves tracking the container ID associated with each job and resetting the metrics if we spot that the ID has changed.

Closes #706

This value gets replaced in both branches of the conditional.
Copy link
Member

@bloodearnest bloodearnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pragmatic fix

@evansd evansd merged commit ef11eac into main Feb 9, 2024
12 checks passed
@evansd evansd deleted the evansd/stats-for-restarted-jobs branch February 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix job metrics for restarts
2 participants