Log and cache OSJobsRepository
#27
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[structlog][] is simple. Much simpler than the standard library's `logging` module. [structlog]: https://www.structlog.org/
We focus on logging calls that cross system boundaries.
We use [`cache_resource`][1] to cache the repository, making it globally available: that is, across all users, sessions, and reruns. Notice that with this commit, a `Measure` is initialised once, and the instance is then reused when the dashboard changes. Previously, a `Measure` was initialised each time the dashboard changed. Notice that `get_repository` allows us to maintain the separation between the presentation (application) layer and the repository. We don't want to see `import streamlit` in `app/measures.py`! [1]: https://docs.streamlit.io/develop/api-reference/caching-and-state/st.cache_resource
alarthast
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience, we add
structlogas a requirement and then use it to log calls withinapp/measures.pythat cross system boundaries. We then cache the repository, making it globally available.It's worth checking out d627c23, switching between measures in the dashboard, and observing the logs. Then checkout 8153638 (
HEAD), and observe the logs again.I wouldn't say any of ☝🏻 is strictly necessary, but it helped me understand more about Streamlit's execution model. It might help you too 🙂