feat: add traceID and pass it to ES #489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds trace IDs to requests as based on https://www.w3.org/TR/trace-context/#processing-model and passes them to ES. The major win here is that we're not breaking traces if we're part of a clients distributed stack.
We're not fully compliant as we're not doing full validation of the incoming traces or inspecting the flags, but we currently correctly participate in or initiate traces and add the trace context to our logs. ES also emits the trace context in logs, but it does not seem like OS supports it quite yet.
I removed our trace ID implementation completely, but we could also deprecate it.