Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handle latest Play 2.2 Version #6

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

JamesSullivan
Copy link

Prior to 2.2 the Unix script to execute Play was named start and it resided in the root level folder of the distribution. With 2.2 the start script is named as per the project’s name and it resides in the distribution’s bin folder. This update to play2-openshift-quickstart includes changes to handle this correctly for Play versions 2.0 through 2.2.

JamesSullivan and others added 29 commits October 2, 2013 15:20
Location of the Unix script that starts a Play application has changed in  2.2. Prior, to 2.2 the Unix script was named start and it resided in the root level folder of the distribution. With 2.2 the start script is named as per the project’s name and it resides in the distribution’s bin folder.
Updating for Play 2.2
corrected path to app name
I had the issue of git push failing due to an error in the stop script: it attempts to pkill java, however, play is not the only java process active, there is also activemq. The app has no permission to kill the activemq process so the stop script fails. These changes rectify this. 
Tested with a local Openshift Origin application.
Update stop: only kill the play process, not any other java processes.
back to killing all java processes to stop as play is not being detected from cut off ps aux text.
In section 'step by step example' link to git repo is in older version (without play 2.2 support). Should be git://github.com/JamesSullivan/play2-openshift-quickstart.git
Noted that for Play 2.3 the play command has been replaced by the activator command and that must be changed in the openshift_deploy script.
Hi James. I had some problem with my app deployed on openshift and just did some digging. My Problem was in this stop script. During executions of this part of code: if [[ -f "RUNNING_PID" ]] ... script is looking for RUNNING_PID inside $OPENSHIFT_REPO_DIR, but there is no such file there. RUNNING_PID is being created inside $OPENSHIFT_REPO_DIR/target/universal/stage/. I tested it and it works for me.
Change openshift.conf to reflect new environment variables for mysql db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants