-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to handle latest Play 2.2 Version #6
Open
JamesSullivan
wants to merge
29
commits into
opensas:master
Choose a base branch
from
JamesSullivan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Location of the Unix script that starts a Play application has changed in 2.2. Prior, to 2.2 the Unix script was named start and it resided in the root level folder of the distribution. With 2.2 the start script is named as per the project’s name and it resides in the distribution’s bin folder.
Updating for Play 2.2
corrected path to app name
I had the issue of git push failing due to an error in the stop script: it attempts to pkill java, however, play is not the only java process active, there is also activemq. The app has no permission to kill the activemq process so the stop script fails. These changes rectify this. Tested with a local Openshift Origin application.
Update stop: only kill the play process, not any other java processes.
back to killing all java processes to stop as play is not being detected from cut off ps aux text.
In section 'step by step example' link to git repo is in older version (without play 2.2 support). Should be git://github.com/JamesSullivan/play2-openshift-quickstart.git
Update README.MD
Noted that for Play 2.3 the play command has been replaced by the activator command and that must be changed in the openshift_deploy script.
Hi James. I had some problem with my app deployed on openshift and just did some digging. My Problem was in this stop script. During executions of this part of code: if [[ -f "RUNNING_PID" ]] ... script is looking for RUNNING_PID inside $OPENSHIFT_REPO_DIR, but there is no such file there. RUNNING_PID is being created inside $OPENSHIFT_REPO_DIR/target/universal/stage/. I tested it and it works for me.
Update stop
Change openshift.conf to reflect new environment variables for mysql db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 2.2 the Unix script to execute Play was named start and it resided in the root level folder of the distribution. With 2.2 the start script is named as per the project’s name and it resides in the distribution’s bin folder. This update to play2-openshift-quickstart includes changes to handle this correctly for Play versions 2.0 through 2.2.