973 remove tapchanger #1174
Merged
973 remove tapchanger #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcvanraalte
requested review from
juancho0202,
pascalwilbrink,
Stef3st and
JakobVogelsang
pascalwilbrink
changed the base branch from
main
to
972_create_wizard_tapchanger
|
closes #973 |
Co-authored-by: Steffen van den Driest <35229971+Stef3st@users.noreply.github.com>
Stef3st
approved these changes
Feb 28, 2023
| @@ -100,7 +100,7 @@ export function contentTapChangerWizard( | |||
| export function createTapChangerWizard(parent: Element): Wizard { | |||
| const name = ''; | |||
| const desc = null; | |||
| const type = null; | |||
| const type = 'LTC'; | |||
There was a problem hiding this comment.
@marcvanraalte I changed the default type from null to LTC as suggested.
marcvanraalte
added a commit
that referenced
this pull request
Mar 2, 2023
* feat(tapchanger-editor.ts):editor_added * feat(tapchanger-editor.test.ts):setup * feat(TapChanger-editor):editor_and_unit_test * feat(tapchanger-editor):start_edit_button * feat(tapchanger-editor):add_edit_wizard * fix(tapChanger.ts)changed_to_tapchanger.ts * feat(tapchanger.ts):create_wizard_added * feat(tapchanger.test.ts):added_create_wizard_test * 973 remove tapchanger (#1174) * feat(tapchanger-editor.ts):remove_added * feat(tapchanger-editor):add_button (#1175) Co-authored-by: Steffen van den Driest <35229971+Stef3st@users.noreply.github.com> * fix: Empty disabled typefield in Add TapChanger --------- Co-authored-by: Steffen van den Driest <35229971+Stef3st@users.noreply.github.com> Co-authored-by: Stef3st <steffen.van.den.driest@alliander.com> * fix: tapchanger file rename * fix:remove 'TapChanger.' text in TapChanger header * fix: removes duplicate snapshot * test: update snapshot to match correct labels --------- Co-authored-by: Steffen van den Driest <35229971+Stef3st@users.noreply.github.com> Co-authored-by: Stef3st <steffen.van.den.driest@alliander.com> Co-authored-by: Juan Muñoz <juan.munoz@alliander.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #973
closes #1185