refactor(ied/da-container,do-container): code improvements

[JakobVogelsang]

@Flurb as you did not like the toggle function I tried to refactor. What do you think.

I do get snapshot updates that I cannot interpret. Maybe you can have a look.

[Flurb]

Way better! Using standard components instead of your own implementation is always better.
I couldn't find one, but I think I might have searched wrong, mwc-icon-button-toggle is perfect here.

[Flurb]

Looks good, but during testing is see that the icon isn't changing when toggling.

[Flurb]

Also, the same toggle principle can be added to the ln-container :)

[JakobVogelsang]

Also, the same toggle principle can be added to the ln-container :)

This was on purpose from my side (see #461). My opinion is that we need some other mechanism here. Do you agree? Do I miss something?

[JakobVogelsang]

Way better! Using standard components instead of your own implementation is always better. I couldn't find one, but I think I might have searched wrong, mwc-icon-button-toggle is perfect here.

This is bug of this component that only is present in debug mode. Just for you to compare, see the buttons in the log.

[Flurb]

Way better! Using standard components instead of your own implementation is always better. I couldn't find one, but I think I might have searched wrong, mwc-icon-button-toggle is perfect here.

This is bug of this component that only is present in debug mode. Just for you to compare, see the buttons in the log.

Then it's fine, hope it will be fixed soon!

[Flurb]

Also, the same toggle principle can be added to the ln-container :)

This was on purpose from my side (see #461). My opinion is that we need some other mechanism here. Do you agree? Do I miss something?

Why would this functionality be different for a LN container compared to DO/DA containers?

[JakobVogelsang]

Also, the same toggle principle can be added to the ln-container :)

This was on purpose from my side (see #461). My opinion is that we need some other mechanism here. Do you agree? Do I miss something?

Why would this functionality be different for a LN container compared to DO/DA containers?

Because rendering the data model for a complicated IED does take some seconds which in my opinion is not a good user experience. The hidden attribute is a performance boost, but as is, we still walk through every DO and DA there is in a data model of an IED. We don't need to do that. I think we should on first render only consider the data model up until the logical nodes and only on toggle button trigger should dive into the DOs and DAs. :)

[Flurb]

I'm going to implement a solution for all three the containers, should not be a problem :)

[Flurb]

@JakobVogelsang (or anyone else) please review :)

[JakobVogelsang]

LGTM @Flurb