-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update WT2 current CE and SE (for ATLAS) #4355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings @wyang007,
Thank you for your pull request.
Your requested changes affect one or more downtime files, but are not eligible for downtime automerge; OSG Staff will need to manually review this PR.
-- OSG-BOT 🔍
Output from the automerge downtime check script:
Old Downtime 1005527 modified for resource 'WT2'
New Downtime 1005527 modified for resource 'WT2_CE'
Commit is not eligible for auto-merge:
- File 'topology/Stanford University/SLAC/WT2.yaml' is not a downtime file.
Hi @wyang007 , would you be able to update this PR to keep the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep old, inactive entries around for record-keeping purposes, WT2_CE should be added as a new entry under WT2
There actually haven't been any records attributed to the old CE in the past 2 years so this PR is fine as is. Approved |
No records attributed to the old CE in the past 2 years so we can reuse the resource name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: WT2 is renamed to WT2_CE in this pull request. This is reflected in both WT2.yaml and WT2_downtime.yaml