Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update WT2 current CE and SE (for ATLAS) #4355

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

wyang007
Copy link
Contributor

@wyang007 wyang007 commented Dec 5, 2024

Note: WT2 is renamed to WT2_CE in this pull request. This is reflected in both WT2.yaml and WT2_downtime.yaml

Copy link
Collaborator

@osg-bot osg-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @wyang007,

Thank you for your pull request.

Your requested changes affect one or more downtime files, but are not eligible for downtime automerge; OSG Staff will need to manually review this PR.

-- OSG-BOT 🔍


Output from the automerge downtime check script:

Old Downtime 1005527 modified for resource 'WT2'
New Downtime 1005527 modified for resource 'WT2_CE'
Commit is not eligible for auto-merge:
 - File 'topology/Stanford University/SLAC/WT2.yaml' is not a downtime file.


@mwestphall
Copy link
Collaborator

Hi @wyang007 , would you be able to update this PR to keep the existing WT2 around with Active: false and create a new entry for WT2_CE? This helps us with continuity for record tracking.

Copy link
Collaborator

@mwestphall mwestphall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep old, inactive entries around for record-keeping purposes, WT2_CE should be added as a new entry under WT2

@brianhlin
Copy link
Member

There actually haven't been any records attributed to the old CE in the past 2 years so this PR is fine as is. Approved

@brianhlin brianhlin dismissed mwestphall’s stale review December 10, 2024 17:01

No records attributed to the old CE in the past 2 years so we can reuse the resource name

Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianhlin brianhlin merged commit 0450ca5 into opensciencegrid:master Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants