Enhance/errors #33
Merged
Enhance/errors #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmeta/functions.py
Outdated
Comment on lines
60
to
64
| for file in dir_list: | ||
| try: | ||
| clear(file) | ||
| except DMetaBaseError as e: | ||
| pass |
There was a problem hiding this comment.
Why you are passing this error?
sadrasabouri
requested changes
Jul 23, 2024
dmeta/params.py
Outdated
| @@ -36,3 +36,8 @@ | |||
| "pptx", | |||
| "xlsx" | |||
| ] | |||
| NOT_IMPLEMENTED_ERROR = "Removing the meta data of this format is not yet supported by DMeta." | |||
There was a problem hiding this comment.
The file format is not supported.
dmeta/params.py
Outdated
| @@ -36,3 +36,8 @@ | |||
| "pptx", | |||
| "xlsx" | |||
| ] | |||
| NOT_IMPLEMENTED_ERROR = "Removing the meta data of this format is not yet supported by DMeta." | |||
| FILE_FORMAT_DOES_NOT_EXIST_ERROR = "Given file name doesn't have a specific format at the end." | |||
There was a problem hiding this comment.
Failed to detect file format. Make sure the file has proper extension (.docx, .pptx, etc.).
dmeta/params.py
Outdated
| @@ -36,3 +36,8 @@ | |||
| "pptx", | |||
| "xlsx" | |||
| ] | |||
| NOT_IMPLEMENTED_ERROR = "Removing the meta data of this format is not yet supported by DMeta." | |||
| FILE_FORMAT_DOES_NOT_EXIST_ERROR = "Given file name doesn't have a specific format at the end." | |||
| INVALID_CONFIG_FILE_NAME_ERROR = "Given config file name should be str not the other type." | |||
There was a problem hiding this comment.
Config file name is not a string.
dmeta/params.py
Outdated
| FILE_FORMAT_DOES_NOT_EXIST_ERROR = "Given file name doesn't have a specific format at the end." | ||
| INVALID_CONFIG_FILE_NAME_ERROR = "Given config file name should be str not the other type." | ||
| CONFIG_FILE_DOES_NOT_EXIST_ERROR = "Given config file doesn't exist." | ||
| UPDATE_COMMAND_WITH_NO_CONFIG_FILE_ERROR = "when using the `update`/`update-all` command, you should set the .json config file through the --config command" |
There was a problem hiding this comment.
No config file provided. Set the .json config file with --config command
sadrasabouri
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?