Skip to content

Conversation

@AHReccese
Copy link
Member

@AHReccese AHReccese commented Feb 15, 2025

Reference Issues/PRs

#53

  • Refactorings ...

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added this to the DMeta v0.4 milestone Feb 15, 2025
@AHReccese AHReccese self-assigned this Feb 15, 2025
@AHReccese AHReccese removed the request for review from sepandhaghighi February 15, 2025 01:02
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thanks for your effort 💯
Please add a section to README.md under the Usage section to inform users they can use this option.

@AHReccese
Copy link
Member Author

@sepandhaghighi
There is another PR which improves the internal functionality of dmeta, I will get back to this PR after merging that PR.

@AHReccese AHReccese force-pushed the add/pre_commit_hook branch from 8db41c4 to a7d43a6 Compare March 4, 2025 14:51
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2025

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 66.02%. Comparing base (4502890) to head (dc8e048).
Report is 40 commits behind head on dev.

Files with missing lines Patch % Lines
dmeta/functions.py 79.32% 2 Missing and 4 partials ⚠️
dmeta/util.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #58      +/-   ##
==========================================
- Coverage   72.08%   66.02%   -6.05%     
==========================================
  Files           4        5       +1     
  Lines         154      206      +52     
  Branches       42       53      +11     
==========================================
+ Hits          111      136      +25     
- Misses         36       49      +13     
- Partials        7       21      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AHReccese AHReccese requested a review from sepandhaghighi May 29, 2025 21:43
@AHReccese
Copy link
Member Author

AHReccese commented May 29, 2025

Dear Sepand (@sepandhaghighi ), since we have not published a version containing the pre-commit hook capability, in order to test it, use this config file:

repos:
  - repo: https://github.com/openscilab/dmeta.git
    rev: dc8e048c35130353e3af7f44b833db3bc46a9d98 
    hooks:
      - id: clear-metadata

@sepandhaghighi
Copy link
Member

Dear Sepand (@sepandhaghighi ), since we have not published a version containing the pre-commit hook capability, in order to test it, use this config file:

repos:
  - repo: https://github.com/openscilab/dmeta.git
    rev: dc8e048c35130353e3af7f44b833db3bc46a9d98 
    hooks:
      - id: clear-metadata

Great job! 💯
I will try it out in the next few days.

@AHReccese AHReccese force-pushed the add/pre_commit_hook branch from d596cca to dc8e048 Compare May 30, 2025 21:39
@AHReccese AHReccese requested a review from sepandhaghighi June 10, 2025 01:32
@AHReccese
Copy link
Member Author

@sepandhaghighi
a kind reminder to review. no rush.

@sepandhaghighi sepandhaghighi merged commit f4a4c7c into dev Jun 10, 2025
42 checks passed
@sepandhaghighi sepandhaghighi deleted the add/pre_commit_hook branch June 10, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants