Skip to content

Conversation

@AHReccese
Copy link
Member

@AHReccese AHReccese commented Jun 19, 2025

Reference Issues/PRs

#46

What does this implement/fix? Explain your changes.

  • Implementing python env detector
  • Handle base-level Audio play in Google Colab

Any other comments?

  • Gradually I will add support for other notebook environments in future PRs

Local tests on OSs

  • macOS
    • Sonoma
  • Windows
    • Windows 11
  • Linux
    • Ubuntu 20.04

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

❌ Patch coverage is 52.63158% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.02%. Comparing base (c0997d1) to head (3181328).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
nava/functions.py 35.72% 17 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #67      +/-   ##
==========================================
- Coverage   93.89%   88.02%   -5.87%     
==========================================
  Files           4        4              
  Lines         229      267      +38     
  Branches       30       36       +6     
==========================================
+ Hits          215      235      +20     
- Misses         11       28      +17     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AHReccese AHReccese marked this pull request as ready for review January 27, 2026 16:45
@AHReccese
Copy link
Member Author

@sadrasabouri
Hi Sadra, you can start to review this PR.

@sadrasabouri
Copy link
Member

I tested it on Colab: it was doing well.
I also tested the manual_test.py and i worked ok Ubuntu. I left a minor comment for you to fix.

@AHReccese
Copy link
Member Author

@sadrasabouri
I addressed your comment, sorry for my confusion.

Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me know. Thank you.

@sadrasabouri sadrasabouri merged commit 266ad83 into dev Feb 3, 2026
34 of 35 checks passed
@sadrasabouri sadrasabouri deleted the notebook/google_colab branch February 3, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants