Skip to content

Minor Fixes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sadrasabouri merged 6 commits into from
Jan 20, 2026
Merged

Minor Fixes #1

sadrasabouri merged 6 commits into from
Jan 20, 2026

Conversation

@sadrasabouri
Copy link
Member

@sadrasabouri sadrasabouri commented Jan 7, 2026

This PR fixes the following in the PyCM API:

  • requirements are now strictly versioned
  • Files have starting line doc-string
  • README.md file updated

@sadrasabouri sadrasabouri self-assigned this Jan 7, 2026
@sadrasabouri sadrasabouri added this to the PyCM API v0.1 milestone Jan 7, 2026
@sadrasabouri sadrasabouri added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 7, 2026
@sadrasabouri sadrasabouri marked this pull request as ready for review January 7, 2026 07:40
alirezazolanvari
alirezazolanvari reviewed Jan 16, 2026
View reviewed changes
Copy link
Member

@alirezazolanvari alirezazolanvari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadrasabouri Thanks for your efforts. The README.md file looks quite comprehensive and well-structured. I just left a minor comment.

alirezazolanvari
alirezazolanvari approved these changes Jan 19, 2026
View reviewed changes
Copy link
Member

@alirezazolanvari alirezazolanvari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. LGTM!

@sadrasabouri sadrasabouri removed the request for review from sepandhaghighi January 20, 2026 05:00
@sadrasabouri
Copy link
Member Author

sadrasabouri commented Jan 20, 2026

Due to the connection issues for @sepandhaghighi I will merge this PR only with one review.

@sadrasabouri sadrasabouri merged commit cbfd86c into dev Jan 20, 2026
@sadrasabouri sadrasabouri deleted the minor-fix branch January 20, 2026 05:01
sadrasabouri added a commit that referenced this pull request Jan 21, 2026
@sadrasabouri
Minor Fixes (#1) (#2)
0049191 
* fix : requirements fixed.

* fix : first line docstring added.

* update : readme updated.

* update : mermaid diagram updated.

* update : mermaid diagram updated.

* fix : arash's comment fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alirezazolanvari alirezazolanvari alirezazolanvari approved these changes

Assignees

@sadrasabouri sadrasabouri

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

PyCM API v0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sadrasabouri @alirezazolanvari