textproc/opensearch: Update to 2.11.1 #3

smortex · 2023-11-12T23:38:06Z

The basic features I use work as expected. Some of you use more advance features, so please report failures.

alonsobsd · 2023-11-13T00:41:54Z

Hello, I was testing this version with wazuh-dashboard-plugins and it breaks completely (wazuh/wazuh-dashboard#113). I guess it was because 2.11.0 removed angularjs. I think the best could be create a opensearch210-dashboard port for wazuh until it can works without problems with opensearch-dashboards >= 2.11.0.

smortex · 2023-11-13T00:57:44Z

You mean this guy was right: opensearch-project/OpenSearch-Dashboards#4993 (comment) ? 😒

And people still ask if it is acceptable to ship features in patch releases 🙄 Good news, this is not what was accepted in the end.

This really gets boring…

+1 for a copy with the MAJOR + MINOR version in the port name, so opensearch210-dashboard or opensearch-dashboard210 maybe more in-line with what is usually done in the ports tree.

hackacad · 2023-11-13T15:27:24Z

Splitting the Port at a minor version does not feel right, but theses changes break certain plugins (maybe more than just Wazuh) we should definitely go for a *210 port. It's already too late for fixing/intervening upstream...

smortex · 2023-11-13T15:49:27Z

I inserted a commit to copy the opensearch-dashboards port. I think it make sense to do the same with opensearch itself, right?

hackacad · 2023-11-13T15:53:24Z

You mean this guy was right: opensearch-project/OpenSearch-Dashboards#4993 (comment) ? 😒

And people still ask if it is acceptable to ship features in patch releases 🙄 Good news, this is not what was accepted in the end.

This really gets boring…

+1 for a copy with the MAJOR + MINOR version in the port name, so opensearch210-dashboard or opensearch-dashboard210 maybe more in-line with what is usually done in the ports tree.

I see multiple new warnings after 2.10-2.11 upgrade:

org.opensearch.core.compress.NotXContentException: Compressor detection can only be called on some xcontent bytes or compressed xcontent bytes
        at org.opensearch.core.compress.CompressorRegistry.compressor(CompressorRegistry.java:75) ~[opensearch-core-2.11.0.jar:2.11.0]

IP Adress check has changed:

{"type":"log","@timestamp":"2023-11-13T15:45:32Z","tags":["error","opensearch","data"],"pid":5653,"message":"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200"}

when using server.host: 0.0.0.0 in a jail (this was just an upgrade, so behavior has definitely changed).

None if these looks like a major issue, but I'd like to do some more testing before pushing this commit.

OpenSeach-Dashboards 2.11.0 introduce some supposed internal changes that break wazuh. Before updating OpenSeach, make the old version available with a new port. With hat: opensearch

With hat: opensearch

With hat: puppet

smortex · 2023-11-13T16:03:01Z

[...]
None if these looks like a major issue, but I'd like to do some more testing before pushing this commit.

Sure! I also experienced some breakage related to the listen address on Linux deployments, but did not dig in (in my case OS listening on localhost was only listening on ::1 while OSD was using 127.0.0.1 to reach OS).

I added commits to copy the existing ports with a 210 suffix. I have not tested it since I don't use wazuh. Please report feedback if you give it a try!

Use opensearch-dashboards like MASTER port

Use textproc/opensearch-dashboards like MASTER port

Use textproc/opensearch-dashboards like MASTERDIR

Use opensearch-dashboards like MASTERDIR

Delete obsolete file

Use textproc/opensearch like MASTERDIR

Delete obsolete file

Use textproc/opensearch like MASTEDIR

Delete obsolete file

alonsobsd · 2023-11-14T23:06:46Z

Hello, I did some modifications to opensearch*-210 ports. Please review those changes

smortex

That looks good. I think the pkg-deinstall.in was not intended for 2.10 only?

Edit: I can't approve this PR because I opened it 🙃

smortex · 2023-11-14T23:32:18Z

textproc/opensearch-dashboards210/files/pkg-deinstall.in

+#!/bin/sh
+
+case "$2" in
+POST-DEINSTALL)
+	if [ -d %%WWWDIR%%/optimize ]; then
+		/usr/bin/find %%WWWDIR%%/optimize/ -delete
+	fi
+
+	cat <<EOMSG
+
+If %%PORTNAME%%%%PKGNAMESUFFIX%% is being deleted permanently, and you do not wish to keep any
+data that was in the cluster, then you may wish to delete the
+%%WWWDIR%% directory.  This can be done by with the command:
+
+	# rm -rf %%WWWDIR%%
+
+Please ignore this if %%PORTNAME%%%%PKGNAMESUFFIX%% is being upgraded
+EOMSG
+    ;;
+esac


Should we not also have this for textproc/opensearch?

I think this file is not being included into opensearch-dashboards port/package. I don't see any SUB_FILES entry into Makefile file

smortex · 2023-11-14T23:33:15Z

textproc/opensearch/Makefile

@@ -14,7 +14,7 @@ BUILD_DEPENDS=	jna>0:devel/jna
 RUN_DEPENDS=	bash>0:shells/bash \
 		jna>0:devel/jna

-CONFLICTS=	opensearch13
+CONFLICTS?=	opensearch13 opensearch210


👍 Yes, I forgot to update the CONFLICTS!

smortex · 2023-11-14T23:34:51Z

textproc/opensearch210/Makefile

+
+MASTERDIR=      ${.CURDIR}/../../textproc/opensearch
+
+.include "${MASTERDIR}/Makefile"


Good idea I think

alonsobsd · 2023-11-14T23:36:30Z

what about remove CHROMIUM from opensearch-dashboards OPTIONS? Really it works from any browser based on chrome. I think the best is put a note into a pkg-message file or just remove the OPTION

- Add pkg-deinstall to SUB_FILES - Define SUB_LIST - Remove CHOMIUM option

Remove obsolete file

smortex · 2023-11-15T02:48:50Z

what about remove CHROMIUM from opensearch-dashboards OPTIONS? Really it works from any browser based on chrome. I think the best is put a note into a pkg-message file or just remove the OPTION

The option is not enabled by default, so no objection to tweak this. I personally don't use this feature 🤷

smortex · 2023-11-18T03:34:19Z

FYI, 2.11.1 is at the corner. I guess we can wait for it before updating?

opensearch-project/opensearch-build#4161

alonsobsd · 2023-11-18T15:13:05Z

FYI, 2.11.1 is at the corner. I guess we can wait for it before updating?

opensearch-project/opensearch-build#4161

I agree. I read it breaks logstash too if I'm not mistaken. Maybe it changes on 2.11.1

smortex · 2023-11-19T07:38:18Z

I agree. I read it breaks logstash too if I'm not mistaken. Maybe it changes on 2.11.1

If I understood correctly, 2.11.1 is intended to fix the regression that break logstash when compression is used in 2.10.0. Not a user of logstash, so I am not affected by this. I guess a few more fixes will be part of the new release.

alonsobsd · 2023-12-16T21:45:56Z

Hello, I have committed opensearch* update and I have added 2.10.0 version too. I did some minor modifications to opensearch ports. Now it is more opensearch friendly ( right permissions to directories and config files)

https://cgit.freebsd.org/ports/commit/?id=c7f140c561d4ab126286d67be6b8377a35d82f04
https://cgit.freebsd.org/ports/commit/?id=1132113d67323e1489cf89af10072cfae7dc36e5

smortex requested review from hackacad and alonsobsd November 12, 2023 23:38

smortex force-pushed the opensearch-2.11.0 branch 2 times, most recently from be0f4d4 to e3f6bef Compare November 13, 2023 15:48

smortex force-pushed the opensearch-2.11.0 branch from e3f6bef to 8becccc Compare November 13, 2023 15:56

smortex added 4 commits November 13, 2023 05:58

textproc/opensearch210: New port

f2df6f7

OpenSeach-Dashboards 2.11.0 introduce some supposed internal changes that break wazuh. Before updating OpenSeach, make the old version available with a new port. With hat: opensearch

textproc/opensearch-dashboards210: New port

3866287

OpenSeach-Dashboards 2.11.0 introduce some supposed internal changes that break wazuh. Before updating OpenSeach, make the old version available with a new port. With hat: opensearch

textproc/opensearch: Update to 2.11.0

84dc787

With hat: opensearch

textproc/opensearch-dashboards: Update to 2.11.0

d41cca9

With hat: puppet

smortex force-pushed the opensearch-2.11.0 branch from 8becccc to d41cca9 Compare November 13, 2023 15:59

alonsobsd added 14 commits November 14, 2023 17:25

Update Makefile

74ecd25

Update Makefile

159a809

Update Makefile

db6da98

Update Makefile

8a91092

Update Makefile

a1d1029

Use opensearch-dashboards like MASTER port

Update Makefile

d650edb

Use textproc/opensearch-dashboards like MASTER port

Update Makefile

36700c7

Use textproc/opensearch-dashboards like MASTERDIR

Update Makefile

56645cb

Use opensearch-dashboards like MASTERDIR

Delete textproc/opensearch-dashboards210/files/opensearch-dashboards.in

c1ed18c

Delete obsolete file

Update Makefile

b9711f1

Use textproc/opensearch like MASTERDIR

Delete textproc/opensearch210/files/opensearch.in

0ee7eff

Delete obsolete file

Update Makefile

10cc2e0

Use textproc/opensearch like MASTEDIR

Delete textproc/opensearch210/files/patch-config_jvm.options

c991833

Delete obsolete file

Delete textproc/opensearch210/files/patch-config_opensearch.yml

1200797

Delete obsolete file

alonsobsd added 3 commits November 14, 2023 17:56

Delete textproc/opensearch210/files/pkg-message.in

4a3fd45

Delete obsolete file

Delete textproc/opensearch-dashboards210/pkg-descr

1979fbf

Delete obsolete file

Delete textproc/opensearch210/pkg-descr

a055360

Delete obsolete file

smortex commented Nov 14, 2023

View reviewed changes

alonsobsd added 2 commits November 14, 2023 19:37

Update Makefile

78fcc75

- Add pkg-deinstall to SUB_FILES - Define SUB_LIST - Remove CHOMIUM option

Delete textproc/opensearch-dashboards210/files/pkg-deinstall.in

423fd93

Remove obsolete file

alonsobsd approved these changes Nov 16, 2023

View reviewed changes

hackacad approved these changes Nov 24, 2023

View reviewed changes

update to 2.11.1

599d231

alonsobsd changed the title ~~textproc/opensearch: Update to 2.11.0~~ textproc/opensearch: Update to 2.11.1 Dec 16, 2023

hackacad closed this Jan 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

textproc/opensearch: Update to 2.11.1 #3

textproc/opensearch: Update to 2.11.1 #3

smortex commented Nov 12, 2023

alonsobsd commented Nov 13, 2023

smortex commented Nov 13, 2023 •

edited

Loading

hackacad commented Nov 13, 2023

smortex commented Nov 13, 2023

hackacad commented Nov 13, 2023 •

edited

Loading

smortex commented Nov 13, 2023

alonsobsd commented Nov 14, 2023

smortex left a comment •

edited

Loading

smortex Nov 14, 2023

alonsobsd Nov 15, 2023

smortex Nov 14, 2023

smortex Nov 14, 2023

alonsobsd commented Nov 14, 2023

smortex commented Nov 15, 2023

smortex commented Nov 18, 2023

alonsobsd commented Nov 18, 2023

smortex commented Nov 19, 2023

alonsobsd commented Dec 16, 2023


		MASTERDIR= ${.CURDIR}/../../textproc/opensearch

		.include "${MASTERDIR}/Makefile"

textproc/opensearch: Update to 2.11.1 #3

textproc/opensearch: Update to 2.11.1 #3

Conversation

smortex commented Nov 12, 2023

alonsobsd commented Nov 13, 2023

smortex commented Nov 13, 2023 • edited Loading

hackacad commented Nov 13, 2023

smortex commented Nov 13, 2023

hackacad commented Nov 13, 2023 • edited Loading

smortex commented Nov 13, 2023

alonsobsd commented Nov 14, 2023

smortex left a comment • edited Loading

Choose a reason for hiding this comment

smortex Nov 14, 2023

Choose a reason for hiding this comment

alonsobsd Nov 15, 2023

Choose a reason for hiding this comment

smortex Nov 14, 2023

Choose a reason for hiding this comment

smortex Nov 14, 2023

Choose a reason for hiding this comment

alonsobsd commented Nov 14, 2023

smortex commented Nov 15, 2023

smortex commented Nov 18, 2023

alonsobsd commented Nov 18, 2023

smortex commented Nov 19, 2023

alonsobsd commented Dec 16, 2023

smortex commented Nov 13, 2023 •

edited

Loading

hackacad commented Nov 13, 2023 •

edited

Loading

smortex left a comment •

edited

Loading