-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text about patch labels for plugin repos #17
Conversation
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
I like it. What does @saratvemulapalli, @nknize or @CEHENKLE think about this? I will go and create the label in all the repos via meta after we merge. |
Its nice, i like it! |
Actually re-reading this I don't think it only applies to plugin repositories as specified. Anything that releases under semver needs patches. I would remove that part. WDYT @ohltyler ? |
@dblock since core is maintaining the third-digit patch version with the labels already (e.g., |
@dblock @saratvemulapalli if both of you agree this can apply to all repos and not just plugins, I'll go ahead and update the text so we can wrap up this PR |
I think it should be applied to all repos, @saratvemulapalli ? |
Sure I agree it should apply to all repos, assuming our versioning will stay consistent across the project. |
@dblock @saratvemulapalli please see updates - removed the wording around the |
I merged this. I'll queue up creating a |
I created patch labels in all repos via https://github.com/opensearch-project/project-meta, |
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
Adds text around plugins having apatch
label to use for any plugin-specific patches (the 4th digit maintained by plugins). This way, the release labels (e.g.,v1.0.0
) can match core (only 3 digits).Adds text around all repositories having an additional
patch
label to track patch commits.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.