Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text about patch labels for plugin repos #17

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jun 23, 2021

Signed-off-by: Tyler Ohlsen ohltyler@amazon.com

Description

Adds text around plugins having a patch label to use for any plugin-specific patches (the 4th digit maintained by plugins). This way, the release labels (e.g., v1.0.0) can match core (only 3 digits).

Adds text around all repositories having an additional patch label to track patch commits.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler changed the title Add patch label for plugin repos Add text about patch labels for plugin repos Jun 23, 2021
@dblock
Copy link
Member

dblock commented Jun 23, 2021

I like it. What does @saratvemulapalli, @nknize or @CEHENKLE think about this?

I will go and create the label in all the repos via meta after we merge.

@saratvemulapalli
Copy link
Member

Its nice, i like it!

@dblock
Copy link
Member

dblock commented Jun 25, 2021

Actually re-reading this I don't think it only applies to plugin repositories as specified. Anything that releases under semver needs patches. I would remove that part. WDYT @ohltyler ?

@ohltyler
Copy link
Member Author

@dblock since core is maintaining the third-digit patch version with the labels already (e.g., v1.0.0), I was thinking it was unnecessary to add a redundant patch label. Although maybe it is still helpful in terms of being consistent with all plugins, so all patch changes can be tracked the same way across the org. I don't have a strong opinion about that either way.

@ohltyler
Copy link
Member Author

@dblock @saratvemulapalli if both of you agree this can apply to all repos and not just plugins, I'll go ahead and update the text so we can wrap up this PR

@dblock
Copy link
Member

dblock commented Jun 25, 2021

@dblock @saratvemulapalli if both of you agree this can apply to all repos and not just plugins, I'll go ahead and update the text so we can wrap up this PR

I think it should be applied to all repos, @saratvemulapalli ?

@saratvemulapalli
Copy link
Member

Sure I agree it should apply to all repos, assuming our versioning will stay consistent across the project.
but keep in mind that there could be outliers like documentation repos, opensearch-build etc.

@ohltyler
Copy link
Member Author

@dblock @saratvemulapalli please see updates - removed the wording around the patch label being plugin-repo-specific.

@dblock dblock merged commit f0c386a into opensearch-project:main Jul 6, 2021
@dblock
Copy link
Member

dblock commented Jul 6, 2021

I merged this. I'll queue up creating a patch label across all repos.

@dblock
Copy link
Member

dblock commented Jul 7, 2021

I created patch labels in all repos via https://github.com/opensearch-project/project-meta, ghi label 'patch' -c '#dd8e2c' if anyone needs to do it on another repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants