Cleanup bug, feature and proposal templates.

[dblock]

Signed-off-by: dblock dblock@amazon.com

Description

Cleanup bug, feature and RFC templates.

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

@elfisher can I please ask you to take a look at this?

[dblock]

@jkowall since you originally PRed #7 please take a look? I am trying to make these templates look similar

Also what emoji should I use?

[elfisher]

This LGTM. Optionally, I'd add in the RFC template a section where authors can request specific things to be commented on.

[jkowall]

@jkowall since you originally PRed #7 please take a look? I am trying to make these templates look similar

Also what emoji should I use?

I think we need a proposal template. I don't understand what RFC would be used for exactly... Unclear the use cases for these.

[dblock]

@jkowall since you originally PRed #7 please take a look? I am trying to make these templates look similar
Also what emoji should I use?

I think we need a proposal template. I don't understand what RFC would be used for exactly... Unclear the use cases for these.

Don't you think that proposal as is is duplicating a feature request? I was thinking RFC is better differentiated from feature requests. RFCs are proposals but more standard. WDYT?

[hyandell]

Something to consider is including "For Security reports, go to X" in the issue reports.

[dblock]

Something to consider is including "For Security reports, go to X" in the issue reports.

When you open an issue in a repo that has a SECURITY.md you see this:

We definitely don't want to add a security template because we don't want people to open security issues (they become 0-days).

So I don't think anything needs to be added, but correct me if I am wrong.

[jkowall]

@jkowall since you originally PRed #7 please take a look? I am trying to make these templates look similar
Also what emoji should I use?

I think we need a proposal template. I don't understand what RFC would be used for exactly... Unclear the use cases for these.

Don't you think that proposal as is is duplicating a feature request? I was thinking RFC is better differentiated from feature requests. RFCs are proposals but more standard. WDYT?

Proposal is for someone who wants to propose and contribute. Feature request is for someone who wants a feature who likely cannot build it (backlog). Up to you.

[dblock]

I see what you mean, @jkowall. I think the questions you ask in a proposal are the same as in an RFC. Am I wrong?

I am thinking of changing "Describe an idea and request comments in this project" to "Make a proposal and request comments in this project" in the template if we believe that's true.

[dblock]

I'd like to merge this, but I want to make sure that @jkowall and @jmazanec15 at least agree that this is an improvement over what we had?

Let me think about what to do this after #19

[dblock]

I made all 3 templates look and feel the same. Most changes are in PROPOSAL_TEMPLATE, but I did not change the material content of it.

@jmazanec15 @jkowall @elfisher take a look?

[dblock]

This is some content from the COC, and some that's general across all issues, so I removed it to avoid saying different things in different places. The comments are also not something GitHub shows in any interesting ways, so I think writers of issues should overwrite the text just like in the bug and feature templates alongside proposal.

Now, if we do think we should have a comment section like this, we can add it in all templates. In this PR I am voting to remove it.

[elfisher]

this LGTM