address comments

Signed-off-by: Su <szhongna@amazon.com>

src/plugins/console/public/lib/mappings/mappings.js

@@ -37,7 +37,7 @@ const POLL_INTERVAL = 60000;
 let pollTimeoutId;
 
 let perIndexTypes = {};
-let perAliasIndexes = {};
+let perAliasIndices = {};
 let templates = [];
 
 export function expandAliases(indicesOrAliases) {
@@ -53,8 +53,8 @@ export function expandAliases(indicesOrAliases) {
   }
 
   indicesOrAliases = indicesOrAliases.map((iOrA) => {
-    if (perAliasIndexes[iOrA]) {
-      return perAliasIndexes[iOrA];
+    if (perAliasIndices[iOrA]) {
+      return perAliasIndices[iOrA];
     }
     return [iOrA];
   });
@@ -148,15 +148,9 @@ export function getTypes(indices) {
 
 export function getIndices(includeAliases) {
   const ret = [];
-  Object.keys(perIndexTypes).forEach((index) => {
-    // ignore .ds* indices in the suggested indices list.
-    if (!index.startsWith('.ds')) {
-      ret.push(index);
-    }
-  });
 
   if (typeof includeAliases === 'undefined' ? true : includeAliases) {
-    Object.keys(perAliasIndexes).forEach((alias) => {
+    Object.keys(perAliasIndices).forEach((alias) => {
       ret.push(alias);
     });
   }
@@ -245,7 +239,7 @@ export function loadMappings(mappings) {
 }
 
 export function loadAliases(aliases) {
-  perAliasIndexes = {};
+  perAliasIndices = {};
   Object.entries(aliases).forEach(([index, omdexAliases]) => {
     // verify we have an index defined. useful when mapping loading is disabled
     perIndexTypes[index] = perIndexTypes[index] || {};
@@ -254,21 +248,21 @@ export function loadAliases(aliases) {
       if (alias === index) {
         return;
       } // alias which is identical to index means no index.
-      let curAliases = perAliasIndexes[alias];
+      let curAliases = perAliasIndices[alias];
       if (!curAliases) {
         curAliases = [];
-        perAliasIndexes[alias] = curAliases;
+        perAliasIndices[alias] = curAliases;
       }
       curAliases.push(index);
     });
   });
 
-  perAliasIndexes._all = getIndices(false);
+  perAliasIndices._all = getIndices(false);
 }
 
 export function clear() {
   perIndexTypes = {};
-  perAliasIndexes = {};
+  perAliasIndices = {};
   templates = [];
 }
 
@@ -283,7 +277,6 @@ function retrieveSettings(http, settingsKey, settingsToRetrieve) {
   if (settingsToRetrieve[settingsKey] === true) {
     return opensearch.send(http, 'GET', settingKeyToPathMap[settingsKey], null);
   } else {
-    // const settingsPromise = new $.Deferred();
     if (settingsToRetrieve[settingsKey] === false) {
       // If the user doesn't want autocomplete suggestions, then clear any that exist
       return Promise.resolve({});