Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] copy as curl doesn't work in Dev Tools #1471

Closed
kavilla opened this issue Apr 16, 2022 · 0 comments · Fixed by #1472
Closed

[BUG] copy as curl doesn't work in Dev Tools #1471

kavilla opened this issue Apr 16, 2022 · 0 comments · Fixed by #1472
Labels
bug Something isn't working v2.0.0

Comments

@kavilla
Copy link
Member

kavilla commented Apr 16, 2022 •
edited
Loading

Describe the bug

Copy as curl doesn't work in Dev Tools console due to usage of a deprecated method:
https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported#browser_compatibility

To Reproduce
Steps to reproduce the behavior:

  1. Go to Dev Tools
  2. Click on a request
  3. Click on copy as curl
  4. Paste and notice that the request was not copied.

Expected behavior
Copied

OpenSearch Version
2.x

Dashboards Version
2.x

Plugins

All

** Browser **

Firefox 91.8.0esr
@kavilla kavilla added bug Something isn't working untriaged v2.0.0 and removed untriaged labels Apr 16, 2022
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Apr 16, 2022
@kavilla
[Bug] fix copy as curl
e66bb05 
Copy as curl doesn't work in Dev Tools console due to usage of a
deprecated method:

https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported#browser_compatibility

Issue Resolved:
opensearch-project#1471

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this issue Apr 16, 2022
Merged
7 tasks
@kavilla kavilla linked a pull request Apr 16, 2022 that will close this issue
[Bug] fix copy as curl #1472
Merged
7 tasks
kavilla added a commit that referenced this issue Apr 21, 2022
@kavilla
[Bug] fix copy as curl (#1472)
376ba8c 
* [Bug] fix copy as curl

Copy as curl doesn't work in Dev Tools console due to usage of a
deprecated method:

https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported#browser_compatibility

Issue Resolved:
#1471

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Adds browser compatibility comment

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 21, 2022
@kavilla @github-actions
[Bug] fix copy as curl (#1472)
dd243f3 
* [Bug] fix copy as curl

Copy as curl doesn't work in Dev Tools console due to usage of a
deprecated method:

https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported#browser_compatibility

Issue Resolved:
#1471

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Adds browser compatibility comment

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
(cherry picked from commit 376ba8c)
kavilla added a commit that referenced this issue Apr 21, 2022
@opensearch-trigger-bot @kavilla
[Bug] fix copy as curl (#1472) (#1483)
39d1641 
* [Bug] fix copy as curl

Copy as curl doesn't work in Dev Tools console due to usage of a
deprecated method:

https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported#browser_compatibility

Issue Resolved:
#1471

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Adds browser compatibility comment

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
(cherry picked from commit 376ba8c)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug] fix copy as curl kavilla/OpenSearch-Dashboards-1
1 participant
@kavilla