Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use opensearch-builds CI runner for functional tests #1651

Open
ashwin-pc opened this issue Jun 2, 2022 · 4 comments
Open

Use opensearch-builds CI runner for functional tests #1651

ashwin-pc opened this issue Jun 2, 2022 · 4 comments
Labels
ci enhancement New feature or request

Comments

@ashwin-pc
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently we use ubuntu-latest runner for our functional tests. because of this we need to manually install the chromedriver npm package to run our functional tests. This package is not always up to date with the latest chrome driver version causing functional test failures in the repo. We already have a runner with all the necessary packages installed in opensearch-build

Describe the solution you'd like

Use the ci runner instead of the default github runner

Describe alternatives you've considered

using a patch version of the chrome driver. This is not ideal because it will still require us to be dependent on the chromedriver npm package in future

Additional context

Add any other context or screenshots about the feature request here.
@ashwin-pc ashwin-pc added the enhancement New feature or request label Jun 2, 2022
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 2, 2022
@kavilla
[CI][BWC] add BWC tests to github actions
a30510e 
Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this issue Jun 2, 2022
Merged
7 tasks
@kavilla
Copy link
Member

kavilla commented Jun 2, 2022 •
edited
Loading

I have it running in the container in this PR #1624 but unfortunately. the user github uses is 1001 and the docker image dumps most of the setup stuff in a folder that isn't just a regular user.

In multiple attempts I tried to have the runner point do work in that expected directory but github actions has verification steps that don't quite make sense to me [link to issue].

So for the time being, the PR I listed above lets us control the chromedriver version and we wont be surprised as much as other as relying on github envs.

@ananzh
Copy link
Member

ananzh commented Jun 2, 2022

@kavilla what PR? link under #1651 is an issue. Could you re-link the PR?

@kavilla
Copy link
Member

kavilla commented Jun 2, 2022 •
edited
Loading

@kavilla what PR? link under #1651 is an issue. Could you re-link the PR?

Good catch! Updated!

ashwin-pc pushed a commit that referenced this issue Jun 2, 2022
@kavilla
[CI][BWC] add BWC tests to github actions (#1624)
35eeb76 
* [CI][BWC] add BWC tests to github actions

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
#1465
#1651

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 2, 2022
@kavilla
[CI][BWC] add BWC tests to github actions (opensearch-project#1624)
ee3d2ae 
Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Backport PR:
opensearch-project#1624

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this issue Jun 2, 2022
Merged
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 3, 2022
@kavilla
[CI][BWC] add BWC tests to github actions (opensearch-project#1624)
4fed386 
Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Backport PR:
opensearch-project#1624

Includes changes from:
opensearch-project#1502

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 3, 2022
@kavilla
[CI][BWC] add BWC tests to github actions (opensearch-project#1624)
fa77bf2 
Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Backport PR:
opensearch-project#1624

Includes changes from:
opensearch-project#1502

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 3, 2022
@kavilla
[Backport 2.x][CI][BWC] add BWC tests to github actions (#1624) (#1659)
af4a2c2 
* [CI][BWC] add BWC tests to github actions (#1624)

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
#1465
#1651

Backport PR:
#1624

Includes changes from:
#1502

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 3, 2022
@kavilla
[Backport 2.0][CI][BWC] add BWC tests to github actions (opensearch-p…
94d34a1 
…roject#1624) (opensearch-project#1659)

[CI][BWC] add BWC tests to github actions (opensearch-project#1624)

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Backport PR:
opensearch-project#1624

Includes changes from:
opensearch-project#1502

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this issue Jun 3, 2022
Merged
kavilla added a commit that referenced this issue Jun 4, 2022
@kavilla
[Backport 2.0][CI][BWC] add BWC tests to github actions (#1624) (#1659)…
f121a0a 
… (#1675)

[CI][BWC] add BWC tests to github actions (#1624)

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
#1465
#1651

Backport PR:
#1624

Includes changes from:
#1502

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 8, 2022
@kavilla
[CI][BWC] add BWC tests to github actions (opensearch-project#1624)
ec30d19 
* [CI][BWC] add BWC tests to github actions

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 8, 2022
@kavilla
[CI][BWC] add BWC tests to github actions (opensearch-project#1624)
189d44e 
* [CI][BWC] add BWC tests to github actions

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 16, 2022
@kavilla
[CI][BWC] add BWC tests to github actions (opensearch-project#1624)
826234a 
* [CI][BWC] add BWC tests to github actions

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this issue Dec 1, 2022
@kavilla
[Backport 2.x][CI][BWC] add BWC tests to github actions (opensearch-p…
9484d51 
…roject#1624) (opensearch-project#1659)

* [CI][BWC] add BWC tests to github actions (opensearch-project#1624)

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Issue:
opensearch-project#1465
opensearch-project#1651

Backport PR:
opensearch-project#1624

Includes changes from:
opensearch-project#1502

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@ashwin-pc
Copy link
Member Author

@kavilla the PR you have linked has been merged, can we close this issue?

@kavilla kavilla added the ci label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kavilla @ashwin-pc @ananzh