Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Modifying the cloned dashboard should not affect the original dashboard #4445

Open
bbarani opened this issue Jun 29, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@bbarani
Copy link
Member

bbarani commented Jun 29, 2023

Describe the bug
Whenever I modify the visualization in cloned dashboard its updating the original dashboard as well

To Reproduce
Steps to reproduce the behavior:
1.) Create a dashboard
2.) Add visualizations to it
3.) Clone the dashboard and provide it a new name
4.) Edit the visualization in cloned dashboard and save it
5.) The original dashboard visualizations are modified based on the changes made to cloned dashboard visualization.

Expected behavior
The cloned dashboard changes doesn't impact the original dashboard

OpenSearch Version
Please list the version of OpenSearch being used.

Dashboards Version
Please list the version of OpenSearch Dashboards being used.

Plugins

Please list all plugins currently enabled.

Screenshots

cloned.dashboard.issue.mp4

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@bbarani bbarani added bug Something isn't working untriaged labels Jun 29, 2023
@AMoo-Miki
Copy link
Collaborator

Dashboards are simply containers to show a bunch of visualizations together. When you create a Dashboard, you link a visualization to it. When you clone a Dashboard, it clones that relationship; it does not clone the visualizations in them.

For your desired behavior, you would want to clone the visualizations as well.

@AMoo-Miki AMoo-Miki added invalid This doesn't seem right and removed untriaged labels Jun 29, 2023
@ashwin-pc ashwin-pc removed the invalid This doesn't seem right label Jun 29, 2023
@ashwin-pc
Copy link
Member

ashwin-pc commented Jun 29, 2023

@bbarani This is a good issue to bring up and would like to know from product/UX how we should handle something like this. what Bharani describes is a behavior that a user might want, but from what @AMoo-Miki describes is not what the clone button is meant to do. Having some sort of toggle when a user clones a dashboard to also clone the visualizations is one way i can see this being addressed.

cc: @dagneyb @KrooshalUX @kgcreative

Rephrasing this to be an enhancement instead of a bug though since the current behavior as Miki mentioned is expected

@ashwin-pc ashwin-pc changed the title [BUG] Modifying the cloned dashboard affects the original dashboard [Feature Request] Modifying the cloned dashboard should not affect the original dashboard Jun 29, 2023
@ashwin-pc ashwin-pc added enhancement New feature or request and removed bug Something isn't working labels Jun 29, 2023
@KrooshalUX
Copy link

KrooshalUX commented Jun 29, 2023

Overall, we need to improve upon communicating to the end user the relationship between visualizations and dashboards. For example - given the recent exploration on color selection of visualizations, it has become clear - that its not clear - what modifications a user can make on a dashboard to a visualization actually change the visualization vs just within the dashboard. Ex: changing colors via the legend (dashboard) doesn't change the base visualization - and can be different between dashboards. This sounds like a good thing - having customization per dashboard vs modifying the visualization, allowing everyone to do what they need at the dashboard level - unless - the user that made those customization and expected them to appear across dashboards.

Correcting the patterns for this can take place across a few projects -the ones that come to mind that we might want to expand scope on to improve this are in the Data Explorer project as well as Projects in #4298 .

For some short term fixes, we may want to add some confirmation modals to edit mode in Dashboard, and the various editing interfaces of visualizations (including vis builder). I can run an inventory on the experiences and provide followup thoughts in this issue. Primarily want to be conscious of adding the right level of friction.

@bbarani
Copy link
Member Author

bbarani commented Jun 29, 2023

One more note: Cloning visualization creates a copy and cloning of dashboards creates sym link. The term 'clone' is very confusing here.

@Jayu8
Copy link

Jayu8 commented Apr 5, 2024

Cx use case: Copy/Mirror/Clone dashboard and change the index pattern

  1. [Feature Request] Modifying the cloned dashboard should not affect the original dashboard #4445
    Copies dashboards with visualisations.
  2. [Discuss] Improve "New visualization" menu to differentiate between types of visualization building methods #3709
    Changes index pattern within visualization.

@kgcreative
Copy link
Member

kgcreative commented Apr 5, 2024

We should take a page from import/export, and introduce an [ ] Also duplicate related objects flag for this. This would not just duplicate the dashboard, but also duplicate the visualizations. We could also introduce a way to prefix or suffix all related saved object names in order to make it easier to find those objects. cc: @BionIT + @ashwin-pc

@ashwin-pc
Copy link
Member

cc: @AMoo-Miki Since you are taking a stab at Dashboards improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants