Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] unit test telemetry_sender.test.ts is skipped now #498

Closed
ananzh opened this issue Jun 18, 2021 · 0 comments
Closed

[Test] unit test telemetry_sender.test.ts is skipped now #498

ananzh opened this issue Jun 18, 2021 · 0 comments
Assignees
@ananzh
Labels
test:unit v1.0.0

Comments

@ananzh
Copy link
Member

ananzh commented Jun 18, 2021

Describe the bug

Currently, telemetry_sender.test.ts test suite is skipped. To make a clean unit test, we want to explore and decide whether we still need to keep it as skipped.

/src/plugins/telemetry/public/services/telemetry_sender.test.ts
Test Suites: 1 skipped, 0 of 1 total
Tests:       16 skipped, 16 total

To Reproduce
Run:yarn test:jest {path to telemetry_sender.test.ts}

Expected behavior
explore the skipped unit tests, check:

  • can we enable all? if yes, create a PR and close the issue

  • can we remove all? if yes, create a PR and close the issue

  • should we keep all? if yes, describe the reasons in the issue.

The final output is expected to be a cleaned unit test with all the skipped ones being checked.

OpenSearch Version
OpenSearch 1.0.0

Dashboards Version
Dashboards 1.0.0
@ananzh ananzh added bug Something isn't working test:unit v1.0.0 untriaged labels Jun 18, 2021
@ananzh ananzh self-assigned this Jun 18, 2021
@ananzh ananzh mentioned this issue Jun 18, 2021
Closed
26 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jun 18, 2021
@ananzh
[Bug] Enable unit test suite: telemetry_sender.test.ts (opensearch-pr…
7f2e731 
…oject#498)

All the unit tests related to unused telemetry are temporarily
skipped at forking. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR modifies and enables
telemetry_sender.test.ts.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh changed the title [BUG] unit test telemetry_sender.test.ts is skipped now [Test] unit test telemetry_sender.test.ts is skipped now Jun 18, 2021
@ananzh ananzh removed the untriaged label Jun 18, 2021
@ananzh ananzh mentioned this issue Jun 18, 2021
Merged
5 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jun 18, 2021
@ananzh
[Test] Enable unit test suite: telemetry_sender.test.ts (opensearch-p…
4a0ad4a 
…roject#498)

All the unit tests related to unused telemetry are temporarily
skipped at forking. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR modifies and enables
telemetry_sender.test.ts.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh removed the bug Something isn't working label Jun 18, 2021
ananzh added a commit that referenced this issue Jun 26, 2021
@ananzh
[Test] Enable unit test suite: telemetry_sender.test.ts (#500)
1e7b8f1 
* [Test] Enable unit test suite: telemetry_sender.test.ts (#498)

All the unit tests related to unused telemetry are temporarily
skipped at forking. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR modifies and enables
telemetry_sender.test.ts.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Test] Enable unit test suite: telemetry_sender.test.ts

Remove all the original comment out lines. If needs
restore the unit test, can revert this commit.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh closed this as completed Jun 26, 2021
kavilla pushed a commit that referenced this issue Jun 26, 2021
@ananzh @kavilla
[Test] Enable unit test suite: telemetry_sender.test.ts (#500)
1f42350 
* [Test] Enable unit test suite: telemetry_sender.test.ts (#498)

All the unit tests related to unused telemetry are temporarily
skipped at forking. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR modifies and enables
telemetry_sender.test.ts.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Test] Enable unit test suite: telemetry_sender.test.ts

Remove all the original comment out lines. If needs
restore the unit test, can revert this commit.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
kavilla pushed a commit that referenced this issue Jun 26, 2021
@ananzh @kavilla
[Test] Enable unit test suite: telemetry_sender.test.ts (#500)
6202d98 
* [Test] Enable unit test suite: telemetry_sender.test.ts (#498)

All the unit tests related to unused telemetry are temporarily
skipped at forking. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR modifies and enables
telemetry_sender.test.ts.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Test] Enable unit test suite: telemetry_sender.test.ts

Remove all the original comment out lines. If needs
restore the unit test, can revert this commit.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
test:unit v1.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ananzh