Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin functional failure] Custom doc link #5370

Open
abbyhu2000 opened this issue Oct 25, 2023 · 3 comments
Open

[Plugin functional failure] Custom doc link #5370

abbyhu2000 opened this issue Oct 25, 2023 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers test:functional

Comments

@abbyhu2000
Copy link
Member

Describe the bug
The custom doc link test test/plugin_functional/test_suites/doc_views_links/doc_views_links.ts fail after this commit got merged in 2.11 branch: 3512117.

However, this commit fixed the previous problematic doc sharing functionality in the discover plugin. And the custom doc link test failed before and was modified in this PR: https://github.com/opensearch-project/OpenSearch-Dashboards/commit/4bfc5e42308187199a752fb3985a4bda81f188bf#diff-fa7289104e843[…]e12dcb8381a6589b825

We should double check and confirm now after the new commit that fixes the sharing link function, if the custom doc link test is fixed without the change in the above PR.

1 failing
     │
     │1)    doc views links
     │       custom doc views links
     │         should render href doc view link:
     │
     │
     │       Error: expected 'http://localhost:5620/app/discover#/context/logstash-*/AU_x3_g4GFA8no6QjkYX?_g=(filters:!())&_a=(columns:!(_source),filters:!())' to sort of equal 'http://some-url/'
     │       + expected - actual
     │ 
     │       -http://localhost:5620/app/discover#/context/logstash-*/AU_x3_g4GFA8no6QjkYX?_g=(filters:!())&_a=(columns:!(_source),filters:!())
     │       +http://some-url/
     │       
     │       at Assertion.assert (packages/osd-expect/expect.js:111:11)
     │       at Assertion.eql (packages/osd-expect/expect.js:255:8)
     │       at Context.<anonymous> (test/plugin_functional/test_suites/doc_views_links/doc_views_links.ts:67:29)
     │       at runMicrotasks (<anonymous>)
     │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
     │       at Object.apply (packages/osd-test/src/functional_test_runner/lib/mocha/wrap_function.js:95:16)
@abbyhu2000 abbyhu2000 added bug Something isn't working good first issue Good for newcomers labels Oct 25, 2023
@willie-hung
Copy link
Contributor

Hi @abbyhu2000 I would like to take a look at this issue. Can you assign me? Thanks

@willie-hung
Copy link
Contributor

willie-hung commented Oct 27, 2023

@abbyhu2000 When setting up the functional test server, I consistently encounter an error related to unavailable snapshots. Is there something I'm overlooking?
Screenshot 2023-10-26 at 9 26 59 PM

@willie-hung
Copy link
Contributor

willie-hung commented Oct 27, 2023

Hmm... it seems like an existing problem for darwin-arm64. opensearch-project/opensearch-build#4131

kavilla pushed a commit that referenced this issue Oct 27, 2023
Add tests for plugin functional on GitHub Actions.

Skip doc tests because of:
#5370

* Add tests for plugin functional
* add changelog
* Skip app link test and fix core plugins test

Issue resolved:
#5382

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 27, 2023
Add tests for plugin functional on GitHub Actions.

Skip doc tests because of:
#5370

* Add tests for plugin functional
* add changelog
* Skip app link test and fix core plugins test

Issue resolved:
#5382

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit b796940)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 27, 2023
Add tests for plugin functional on GitHub Actions.

Skip doc tests because of:
#5370

* Add tests for plugin functional
* add changelog
* Skip app link test and fix core plugins test

Issue resolved:
#5382

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit b796940)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
abbyhu2000 pushed a commit that referenced this issue Oct 27, 2023
Add tests for plugin functional on GitHub Actions.

Skip doc tests because of:
#5370

* Add tests for plugin functional
* add changelog
* Skip app link test and fix core plugins test

Issue resolved:
#5382

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit b796940)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this issue Oct 30, 2023
Add tests for plugin functional on GitHub Actions.

Skip doc tests because of:
#5370

* Add tests for plugin functional
* add changelog
* Skip app link test and fix core plugins test

Issue resolved:
#5382

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit b796940)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers test:functional
Projects
None yet
Development

No branches or pull requests

2 participants