Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Data Explorer] Save search embeddable rendering error on dashboard causing adding new embeddable problematic #5415

Closed
abbyhu2000 opened this issue Oct 31, 2023 · 0 comments
Assignees
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent v2.11.1 Issues targeting release v2.11.1

Comments

@abbyhu2000
Copy link
Member

Describe the bug
Since save search embeddable is rendering incorrectly on dashboard #5117, the saved search now is rendering 100 lines on dashboard page and it takes too much space for me(100 lines take almost an entire page), now adding any new embeddable/visualizations to dashboard can not be rendered or displayed correctly, it renders behind the save search embeddable like a shadow.

Issues start occurring after 2.10 when discover is replaced with data explorer.
2.10 version with the legacy discover works fine. Previously the saved search render much less rows that contained in a box and does not take so much space.

To Reproduce

Screen.Recording.2023-10-31.at.4.01.02.PM.mov
@abbyhu2000 abbyhu2000 added bug Something isn't working untriaged data explorer Issues related to the Data Explorer project discover for discover reinvent labels Oct 31, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 7, 2023
…Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5440
opensearch-project#5415

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 7, 2023
…Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5440
opensearch-project#5415

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 7, 2023
…Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5440
opensearch-project#5415

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 7, 2023
…Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5440
opensearch-project#5415

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh added v2.11.1 Issues targeting release v2.11.1 and removed v2.12.0 labels Nov 7, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 8, 2023
* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5415

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 8, 2023
…Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5415
opensearch-project#5440

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 8, 2023
* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5415

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 8, 2023
* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5415

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Nov 8, 2023
* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
opensearch-project#5415

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh closed this as completed in e0b6006 Nov 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this issue Nov 9, 2023
* [BUG] Fix Discover table panel size auto adjust in Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
#5415

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit e0b6006)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this issue Nov 9, 2023
* [BUG] Fix Discover table panel size auto adjust in Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
#5415

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit e0b6006)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ananzh pushed a commit that referenced this issue Nov 9, 2023
…5452)

* [BUG] Fix Discover table panel size auto adjust in Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
#5415

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit e0b6006)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this issue Nov 9, 2023
…5453)

* [BUG] Fix Discover table panel size auto adjust in Dashboard

* Add React.memo on parent comp
* Restore embeddable panel style

Issue Resolve
#5415

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit e0b6006)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent v2.11.1 Issues targeting release v2.11.1
Projects
None yet
Development

No branches or pull requests

3 participants