Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades babel, storybook, and postcss dependencies #1056

Commits on Dec 29, 2021

  1. [draft] Node.js upgrade from 10 to 14

    * precommit checks are failing with an error related to an lmdb-store dependency
    * unit tests are failing with an error related to lmdb-store
    * bumped react from 16.12 to 16.14 to resolve unmet peer dependencies, but we still need a resolution to remove the old version
    * need a replacement for @elastic/good
    
    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Tommy Markley committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    7d7d88d View commit details
    Browse the repository at this point in the history
  2. Adds transformIgnorePattern for lmdb-store and dependencies

    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Bishoy Boktor authored and Tommy Markley committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    42cc804 View commit details
    Browse the repository at this point in the history
  3. Removes lmdb-store from transformIgnorePatterns and fixes unit test j…

    …est issues (opensearch-project#1012)
    
    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    boktorbb authored and Tommy Markley committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    40bab5e View commit details
    Browse the repository at this point in the history
  4. [CI] Add tests to github workflow

    Add unit tests to github workflow and also creating a "bad apples"
    environment variable. Some unit tests just fail on the CI for
    hardware issues. They should be improved but step one will be
    calling out the bad apples.
    
    Also due to the flakiness we can cache the previous run results
    and only run the tests that failed. It's too random to catch
    with the bad apples mechanism. But still added the continue on
    error for unit tests because it takes so long to re-run on the
    CI. So instead if it does fail we automatically echo there
    was a failure and ask them to re-run. However, if we can get
    permission for a github action that can add a comment to the PR
    then we could automatically add to PR.
    
    Next step will be improving.
    
    Also needed to limit the amount of workers because otherwise the
    hardware can't handle well so then it will accidentally create conflicts.
    This means we get an accurate test run but it is slower on the CI.
    
    Included integration tests which worked out of the box.
    
    Included e2e tests as well but it the chrome driver for the application
    was different from github's chrome so to run it I just upgraded it for
    the test run. Not ideal, ideally we should probably set up a
    docker env and install the specific versions since we are now
    depending on github's virtual env and the dependencies they installed
    there. But at least this is a first pace.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla authored and Tommy Markley committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    ff9a331 View commit details
    Browse the repository at this point in the history
  5. Skips flaky server metrics collector tests

    * Adds `--no-deprecation` flag for integration tests caused by `shot`
    which is a downstream dependency of `hapi`.
    * The ServerMetricsCollector tests are flaky and rely on the existing
    v17 hapi library that Dashboards depends on. This will be upgraded
    for the 2.0 release along with the Node.js upgrade.
    
    Signed-off-by: Tommy Markley <markleyt@amazon.com>
    Tommy Markley committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    faf480a View commit details
    Browse the repository at this point in the history
  6. Update node version in github workflow to 14

    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Bishoy Boktor authored and Tommy Markley committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    362de41 View commit details
    Browse the repository at this point in the history
  7. Bumps node to 14.18.2 and uses caret range for @types/node

    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Bishoy Boktor authored and Tommy Markley committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    948c923 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Upgrade babel, storybook, and postcss dependencies

    * Upgrades dependencies to resolve react-dev-utils CVE.
    * Have to stay on v6.3.x for @storybook dependencies because of storybookjs/storybook#16837. 6.3.x still depends on older versions of some of the @babel libraries.
    * autoprefixer upgrade removes the browserslist warning during the build.
    * css-loader, postcss-loader, postcss upgrades were required to fix webpack errors. These upgrades contained a few breaking changes.
    * Minor version bumps to react-router, react-router-dom, and styled-components done while troubleshooting bootstrap issues.
    
    Resolves opensearch-project#1055
    
    Signed-off-by: Tommy Markley <markleyt@amazon.com>
    Tommy Markley committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    fb233f0 View commit details
    Browse the repository at this point in the history