Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] upgrade to chromedriver 97 for github actions #1144

Merged
merged 1 commit into from
Jan 13, 2022
Merged

[CI] upgrade to chromedriver 97 for github actions #1144

merged 1 commit into from
Jan 13, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jan 13, 2022 •
edited
Loading

Description

Github virtual env upgraded chrome:
actions/runner-images#4861

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@kavilla
[CI] upgrade to chromedriver 97 for github actions
873dc9f 
Github virtual env upgraded chrome:
actions/runner-images#4861

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from a team as a code owner January 13, 2022 21:09
@kavilla kavilla added the ci label Jan 13, 2022
@kavilla
Copy link
Member Author

kavilla commented Jan 13, 2022

Example results: https://github.com/kavilla/OpenSearch-Dashboards-1/actions/runs/1694257845

tmarkley
tmarkley approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Does GitHub have an open Issue to address this situation so that it doesn't break everyone when they make changes?

@kavilla
Copy link
Member Author

kavilla commented Jan 13, 2022

Looks good! Does GitHub have an open Issue to address this situation so that it doesn't break everyone when they make changes?

As far as I'm aware, no. I think there has been multiple issues to not break folks like this but they get closed. Hence why people just end up using docker images to run their CI on.

@kavilla kavilla merged commit 1106bc1 into opensearch-project:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuochengding zuochengding zuochengding approved these changes

@tmarkley tmarkley tmarkley approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@boktorbb boktorbb Awaiting requested review from boktorbb

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavilla @tmarkley @zuochengding