Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps chromedriver to v100 #1410

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

boktorbb
Copy link
Contributor

Signed-off-by: Bishoy Boktor boktorbb@amazon.com

Description

Bump Chromedriver to version 100 to match github

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb requested a review from a team as a code owner March 31, 2022 17:22
@boktorbb boktorbb merged commit 6ec2182 into opensearch-project:main Mar 31, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1410-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6ec2182c3de581027eccb19d3d1938a7c8789261
# Push it to GitHub
git push --set-upstream origin backport/backport-1410-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-1410-to-1.x.

tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this pull request Apr 25, 2022
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this pull request Apr 25, 2022
Backport 6ec2182 from opensearch-project#1410

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Tommy Markley <markleyt@amazon.com>
ananzh pushed a commit that referenced this pull request Apr 29, 2022
Backport 6ec2182 from #1410

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Tommy Markley <markleyt@amazon.com>
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this pull request Apr 29, 2022
…ect#1495)

Backport 6ec2182 from opensearch-project#1410

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Tommy Markley <markleyt@amazon.com>
tmarkley pushed a commit that referenced this pull request Apr 29, 2022
Backport 6ec2182 from #1410

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Tommy Markley <markleyt@amazon.com>
@ashwin-pc ashwin-pc changed the title bumps chromedriver to v100 Bumps chromedriver to v100 Nov 4, 2022
@tmarkley tmarkley mentioned this pull request Dec 3, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants