Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] vis_type_vislib plugin #151

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 10, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issue #, if available:
#37

Description of changes:
Rename files and variables within plugins/vislib

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove snaps file, rest looks good to me

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.

@mihirsoni mihirsoni merged commit 59cb0e8 into opensearch-project:dashboards Mar 12, 2021
@kavilla kavilla deleted the rename-vislib branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 13, 2023
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…ate (opensearch-project#151) (opensearch-project#154)

(cherry picked from commit bb2d886)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants