Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.0] [Bug] fix missing discover context icon #1565

Merged
merged 1 commit into from
May 10, 2022
Merged

[Backport 2.0] [Bug] fix missing discover context icon #1565

merged 1 commit into from
May 10, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bd10227 from #1545

@joshuarrrr @github-actions
[Bug] fix missing discover context icon (#1545)
903f82a 
add back icon directive, which injects SVG

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit bd10227)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner May 6, 2022 18:46
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (2.0@6039b81). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head bd10227 differs from pull request most recent head 903f82a. Consider uploading reports for the commit 903f82a to get more accurate results

@@          Coverage Diff           @@
##             2.0    #1565   +/-   ##
======================================
  Coverage       ?   68.09%           
======================================
  Files          ?     3072           
  Lines          ?    59033           
  Branches       ?     8928           
======================================
  Hits           ?    40201           
  Misses         ?    16646           
  Partials       ?     2186

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6039b81...903f82a. Read the comment docs.

kavilla
kavilla reviewed May 6, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily related to this PR but we should create a new release doc for 2.0.0 copy over the changes from 2.0.0-rc1.

And start creating a requirement to update the doc if it has the backport to 2.0 label.

@tmarkley
Copy link
Contributor

tmarkley commented May 6, 2022

Not necessarily related to this PR but we should create a new release doc for 2.0.0 copy over the changes from 2.0.0-rc1.

And start creating a requirement to update the doc if it has the backport to 2.0 label.

@kavilla good callout, I can do that. Tracking in #1566.

@tmarkley
Copy link
Contributor

tmarkley commented May 6, 2022

@kavilla #1567

@tmarkley tmarkley merged commit 5c00c1e into 2.0 May 10, 2022
@github-actions github-actions bot deleted the backport/backport-1545-to-2.0 branch May 10, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
v2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @tmarkley @joshuarrrr @kavilla