Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Chore/migrate mocha tests #1678

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0e41477 from #1553

- `src/dev`
  - migrate mocha tests to jest
- `src/test_utils`
  - migrate mocha tests to jest
- `src/dev/license_checker`
  - migrate mocha tests to jest
- `src/legacy/utils`
  - migrate mocha tests to jest
  - convert to typescript
  - add unit test for `version.ts`
- `src/plugins/console/server`
  - migrate mocha tests to jest
  - convert to typescript
  - fix type errors
  - improve test cases
  - update URL parsing
- `packages/opensearch-datemath
  - migrate mocha tests to jest
  - convert to typescript
- `packages/osd-eslint-plugin-eslint`
  - migrate mocha tests to jest
  - rename test file directory
- `packages/osd-opensearch-archiver`
  - migrate mocha tests to jest
  - rename stub directory
- `packages/osd-test`
  - migrate mocha tests to jest
  - remove mocha timeouts (not needed in jest)
  - linting fixes
- `packages/osd-test-subject-selector`
  - migrate mocha tests to jest
  - convert to typescript
  - update tsconfig to transpile ts
  - switch to named exports/imports

Verified that 410 of previous 411 mocha test cases are correctly ran by jest.
Mocha: 1 passing test (mocha report generation, which will be removed in #1572)
Jest: 11155 passing tests (11155 = 10741 previous jest tests + 4 newly added jest test + 410 migrated mocha tests)

Resolves #215

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 0e41477)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner June 6, 2022 19:45
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (2.x@7beca62). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0e41477 differs from pull request most recent head fadfd33. Consider uploading reports for the commit fadfd33 to get more accurate results

@@          Coverage Diff           @@
##             2.x    #1678   +/-   ##
======================================
  Coverage       ?   67.52%           
======================================
  Files          ?     3067           
  Lines          ?    58973           
  Branches       ?     8944           
======================================
  Hits           ?    39822           
  Misses         ?    16972           
  Partials       ?     2179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7beca62...fadfd33. Read the comment docs.

@tmarkley tmarkley merged commit 5f07768 into 2.x Jun 7, 2022
@github-actions github-actions bot deleted the backport/backport-1553-to-2.x branch June 7, 2022 14:48
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
…arch-project#1678)

- `src/dev`
  - migrate mocha tests to jest
- `src/test_utils`
  - migrate mocha tests to jest
- `src/dev/license_checker`
  - migrate mocha tests to jest
- `src/legacy/utils`
  - migrate mocha tests to jest
  - convert to typescript
  - add unit test for `version.ts`
- `src/plugins/console/server`
  - migrate mocha tests to jest
  - convert to typescript
  - fix type errors
  - improve test cases
  - update URL parsing
- `packages/opensearch-datemath
  - migrate mocha tests to jest
  - convert to typescript
- `packages/osd-eslint-plugin-eslint`
  - migrate mocha tests to jest
  - rename test file directory
- `packages/osd-opensearch-archiver`
  - migrate mocha tests to jest
  - rename stub directory
- `packages/osd-test`
  - migrate mocha tests to jest
  - remove mocha timeouts (not needed in jest)
  - linting fixes
- `packages/osd-test-subject-selector`
  - migrate mocha tests to jest
  - convert to typescript
  - update tsconfig to transpile ts
  - switch to named exports/imports

Verified that 410 of previous 411 mocha test cases are correctly ran by jest.
Mocha: 1 passing test (mocha report generation, which will be removed in opensearch-project#1572)
Jest: 11155 passing tests (11155 = 10741 previous jest tests + 4 newly added jest test + 410 migrated mocha tests)

Resolves opensearch-project#215

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 0e41477)
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
…arch-project#1678)

- `src/dev`
  - migrate mocha tests to jest
- `src/test_utils`
  - migrate mocha tests to jest
- `src/dev/license_checker`
  - migrate mocha tests to jest
- `src/legacy/utils`
  - migrate mocha tests to jest
  - convert to typescript
  - add unit test for `version.ts`
- `src/plugins/console/server`
  - migrate mocha tests to jest
  - convert to typescript
  - fix type errors
  - improve test cases
  - update URL parsing
- `packages/opensearch-datemath
  - migrate mocha tests to jest
  - convert to typescript
- `packages/osd-eslint-plugin-eslint`
  - migrate mocha tests to jest
  - rename test file directory
- `packages/osd-opensearch-archiver`
  - migrate mocha tests to jest
  - rename stub directory
- `packages/osd-test`
  - migrate mocha tests to jest
  - remove mocha timeouts (not needed in jest)
  - linting fixes
- `packages/osd-test-subject-selector`
  - migrate mocha tests to jest
  - convert to typescript
  - update tsconfig to transpile ts
  - switch to named exports/imports

Verified that 410 of previous 411 mocha test cases are correctly ran by jest.
Mocha: 1 passing test (mocha report generation, which will be removed in opensearch-project#1572)
Jest: 11155 passing tests (11155 = 10741 previous jest tests + 4 newly added jest test + 410 migrated mocha tests)

Resolves opensearch-project#215

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 0e41477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants