[Backport 2.0] Fix wms maps can't load when can't request default map service #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fix WMS can't load when unable access maps services Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit b2cfb6e)
tmarkley
approved these changes
Jun 13, 2022
ashwin-pc
reviewed
Jun 13, 2022
| return openSearchMapsClient; | ||
| } | ||
|
|
||
| it('isEnabled() should return true when catch error', async function () { |
There was a problem hiding this comment.
This test description could be worded better. What is the purpose of this test?
ashwin-pc
approved these changes
Jun 13, 2022
pjfitzgibbons
pushed a commit
to pjfitzgibbons/OpenSearch-Dashboards
that referenced
this pull request
Oct 24, 2022
…ct#1550) (opensearch-project#1707) * Fix WMS can't load when unable access maps services Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit b2cfb6e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b2cfb6e from #1550