Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Change name of expanded header config #1802

Merged
merged 1 commit into from
Jun 24, 2022
Merged

[UX] Change name of expanded header config #1802

merged 1 commit into from
Jun 24, 2022

Conversation

joshuarrrr
Copy link
Member

@joshuarrrr joshuarrrr commented Jun 24, 2022 •
edited
Loading

Description

useExpandedHeader instead of useExpandedMenu

Issues Resolved

fixes #1583

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@joshuarrrr
[UX] Change name of expanded header config
ab1a6ec 
`useExpandedHeade`r instead of `useExpandedMenu`

fixes opensearch-project#1593

Signed-off-by: Josh Romero <rmerqg@amazon.com>
@joshuarrrr joshuarrrr requested a review from a team as a code owner June 24, 2022 22:44
@codecov-commenter
Copy link

Codecov Report

Merging #1802 (ab1a6ec) into main (ae6cb80) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1802      +/-   ##
==========================================
+ Coverage   67.50%   67.51%   +0.01%     
==========================================
  Files        3074     3074              
  Lines       59127    59127              
  Branches     8988     8988              
==========================================
+ Hits        39911    39917       +6     
+ Misses      17031    17027       -4     
+ Partials     2185     2183       -2
Impacted Files Coverage Δ
src/core/server/opensearch_dashboards_config.ts 100.00% <ø> (ø)
src/core/server/rendering/rendering_service.tsx 66.23% <0.00%> (ø)
src/legacy/server/config/schema.js 100.00% <ø> (ø)
src/core/public/core_system.ts 91.56% <50.00%> (ø)
src/core/public/chrome/ui/header/header.tsx 73.33% <100.00%> (ø)
src/core/public/chrome/ui/header/home_icon.tsx 100.00% <100.00%> (ø)
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (+0.88%) ⬆️
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6cb80...ab1a6ec. Read the comment docs.

seanneumann
seanneumann approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuarrrr joshuarrrr merged commit 6ad5d08 into opensearch-project:main Jun 24, 2022
@joshuarrrr joshuarrrr deleted the ux/header-config-name-change branch June 24, 2022 23:32
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 24, 2022
@joshuarrrr @github-actions
[UX] Change name of expanded header config (#1802)
a0753a2 
`useExpandedHeader` instead of `useExpandedMenu`

fixes #1583

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 6ad5d08)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 24, 2022
Merged
kavilla pushed a commit that referenced this pull request Jun 25, 2022
@opensearch-trigger-bot @joshuarrrr
[UX] Change name of expanded header config (#1802) (#1803)
a4d1cb1 
`useExpandedHeader` instead of `useExpandedMenu`

fixes #1583

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 6ad5d08)

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manasvinibs manasvinibs manasvinibs approved these changes

@seanneumann seanneumann seanneumann approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

Assignees
No one assigned
Labels
backport 2.x branding v2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UX] Redesigned Global Header
4 participants
@joshuarrrr @codecov-commenter @seanneumann @manasvinibs