Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecation] Deprecate the Blacklist / Whitelist nomenclature #1808
[Deprecation] Deprecate the Blacklist / Whitelist nomenclature #1808
Changes from 23 commits
255a391
4269b60
7ee7346
6db590b
813a5ea
7b0cf8b
a13d989
fb4f5bb
860ed2c
5f31aea
2e64a2b
ce40ee3
f6df6ba
5d02dae
09c1b8c
6661f96
9803835
2c650ff
48badf8
9181326
2e8798a
3c7ba2f
72a587f
e81d627
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this we should still use
deprecations
within the index file like the other instances of deprecating.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like add the deprecation here that why no logic needs to change: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/maps_legacy/server/index.ts#L53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.