-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] timelion to timeline (#37) #186
Merged
boktorbb
merged 1 commit into
opensearch-project:dashboards
from
boktorbb:rename-timelion
Mar 18, 2021
Merged
[Rename] timelion to timeline (#37) #186
boktorbb
merged 1 commit into
opensearch-project:dashboards
from
boktorbb:rename-timelion
Mar 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
✅ DCO Check Passed |
mihirsoni
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
LGTM, runs fine. Just linter fails for 12 errors but just needs rebasing so it might not be worth it. |
kavilla
approved these changes
Mar 18, 2021
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Sep 26, 2023
…arch-project#186) * Support to display workspace feature configured with wildcard 1. In workspace update page, support to display workspace feature configured with wildcard. 2. Fixed an issue which generateWorkspacePermissionError return void 3. Fixed an issue which workspace route validation failed due to missing permission mode in schema Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * update dependence array Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 9, 2023
…arch-project#186) * Support to display workspace feature configured with wildcard 1. In workspace update page, support to display workspace feature configured with wildcard. 2. Fixed an issue which generateWorkspacePermissionError return void 3. Fixed an issue which workspace route validation failed due to missing permission mode in schema Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * update dependence array Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishoy Boktor boktorbb@amazon.com